From owner-freebsd-current  Tue Feb 18  8: 5: 7 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F0C3E37B401
	for <current@FreeBSD.org>; Tue, 18 Feb 2003 08:05:05 -0800 (PST)
Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4788343FCB
	for <current@FreeBSD.org>; Tue, 18 Feb 2003 08:05:05 -0800 (PST)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	by gw.nectar.cc (Postfix) with ESMTP
	id D49225F; Tue, 18 Feb 2003 10:05:04 -0600 (CST)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 4407F78C39; Tue, 18 Feb 2003 10:04:42 -0600 (CST)
Date: Tue, 18 Feb 2003 10:04:42 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Dag-Erling Smorgrav <des@ofug.org>
Cc: Kris Kennaway <kris@obsecurity.org>, current@FreeBSD.org
Subject: Re: memset prototype changed?
Message-ID: <20030218160442.GB81793@madman.celabo.org>
References: <20030218105240.GH92966@rot13.obsecurity.org> <xzpheb1yhrq.fsf@flood.ping.uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xzpheb1yhrq.fsf@flood.ping.uio.no>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.3i-ja.1
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Tue, Feb 18, 2003 at 12:01:29PM +0100, Dag-Erling Smorgrav wrote:
> Kris Kennaway <kris@obsecurity.org> writes:
> > http://bento.freebsd.org/errorlogs/i386-5-latest/netatalk-1.6.0_1,1.log
> 
> The code that fails to compile is blatantly wrong:
> 
>     memset(schedule, 0, sizeof(schedule));

I wouldn't say `blantantly'.  The expressions `schedule' and
`&schedule' are equivalent when `schedule' is an array type.
I'd call it `ignoring an idiom'.

Anyway, with libdes or OpenSSL < 0.9.7, the type of `schedule'
would have been an array.  With OpenSSL >= 0.9.7, the type of
`schedule' is a struct.

This port uses <des.h>, which we have as a symlink to <openssl/des.h>
(ugh, I'd better remove that, too).  If that include is replaced with
e.g.

  #ifdef HAVE_OPENSSL
  #define OPENSSL_DES_LIBDES_COMPATIBILITY
  #include <openssl/des.h>
  #else
  #include <des.h>
  #endif

things will be fine.
-- 
Jacques A. Vidrine <nectar@celabo.org>          http://www.celabo.org/
NTT/Verio SME          .     FreeBSD UNIX     .       Heimdal Kerberos
jvidrine@verio.net     .  nectar@FreeBSD.org  .          nectar@kth.se

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message