From owner-freebsd-rc@FreeBSD.ORG  Fri Jun  9 00:54:23 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@freebsd.org
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ED5EF16A418
	for <freebsd-rc@freebsd.org>; Fri,  9 Jun 2006 00:54:23 +0000 (UTC)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 64C4E43D49
	for <freebsd-rc@freebsd.org>; Fri,  9 Jun 2006 00:54:23 +0000 (GMT)
	(envelope-from brdavis@odin.ac.hmc.edu)
Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1])
	by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id k590sME2000446;
	Thu, 8 Jun 2006 17:54:22 -0700
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id k590sMEU000445;
	Thu, 8 Jun 2006 17:54:22 -0700
Date: Thu, 8 Jun 2006 17:54:22 -0700
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Doug White <dwhite@gumbysoft.com>
Message-ID: <20060609005422.GA25288@odin.ac.hmc.edu>
References: <200606082130.k58LUYQO069255@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24"
Content-Disposition: inline
In-Reply-To: <200606082130.k58LUYQO069255@freefall.freebsd.org>
User-Agent: Mutt/1.4.1i
X-Virus-Scanned: by amavisd-new
Cc: freebsd-rc@freebsd.org
Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev
	state
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jun 2006 00:54:24 -0000


--u3/rZRmxL6MmkK24
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 08, 2006 at 09:30:34PM +0000, Doug White wrote:
> The following reply was made to PR conf/94377; it has been noted by GNATS.
>=20
> From: Doug White <dwhite@gumbysoft.com>
> To: Rostislav Krasny <rosti.bsd@gmail.com>
> Cc: Florent Thoumie <flz@FreeBSD.org>, Doug White <dwhite@FreeBSD.org>,=
=20
>     bug-followup@FreeBSD.org
> Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random =
dev
>  state
> Date: Thu, 8 Jun 2006 10:36:05 -0700 (PDT)
>=20
>  On Thu, 8 Jun 2006, Rostislav Krasny wrote:
> =20
>  > I've seen that patch just today, when it is already MFCed. I think it
>  > could be simpler. Instead of
>  >
>  > [ "x${seeded}" !=3D "x" ] && [ ${seeded} -eq 0 ]
>  >
>  > you can write just
>  >
>  > [ "${seeded}" =3D "0" ]
>  >
>  > and it will be still correct against sysctl failing and returning an
>  > empty string.
> =20
>  No, because if ${seeded} is empty, the shell interprets the test as
> =20
>  [ =3D "0" ]
> =20
>  which results in a syntax error. The 'x' in the first test is significan=
t.

Not true.  The 'x' bit has been unnecessicary 31337 for quite some
time IMO.  If you didn't quote ${seeded} then it would be, but
"${variable_that_expands_to_null}" is "". Otherwise -z and -n wouldn't
work.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--u3/rZRmxL6MmkK24
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFEiMa+XY6L6fI4GtQRAqHvAJ9qm2bwN/Iqe01MgSKycudbnDuC8gCfcn3a
TbajPJMl5kzciV6Roei7oH4=
=1m1M
-----END PGP SIGNATURE-----

--u3/rZRmxL6MmkK24--