From owner-freebsd-audit Mon Jul 15 12:24:17 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 772FF37B400; Mon, 15 Jul 2002 12:24:15 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3148B43E42; Mon, 15 Jul 2002 12:24:14 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g6FJNm1f008781; Mon, 15 Jul 2002 13:23:50 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 15 Jul 2002 13:23:23 -0600 (MDT) Message-Id: <20020715.132323.19489929.imp@bsdimp.com> To: keramida@FreeBSD.org Cc: bde@zeta.org.au, des@ofug.org, freebsd-audit@FreeBSD.org Subject: Re: bin/ln & WARNS=5 From: "M. Warner Losh" In-Reply-To: <20020715182514.GC55859@hades.hell.gr> References: <20020715111436.GD50130@hades.hell.gr> <20020715.090420.83279095.imp@bsdimp.com> <20020715182514.GC55859@hades.hell.gr> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This looks good to me. I'd quibble over sizeof path vs sizeof(path), but that's not enough for you to necessarily change it :-). We've also used snprintf in preference to sprintf because the former is a failsafe interface, while the latter could do weird things if our checks are incoorect for some reason. The + 2 looks good to me, and I agree with it. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message