From owner-svn-src-head@freebsd.org Wed Oct 4 15:07:37 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FE75E3B9D8; Wed, 4 Oct 2017 15:07:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x232.google.com (mail-pg0-x232.google.com [IPv6:2607:f8b0:400e:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0D23A659A5; Wed, 4 Oct 2017 15:07:37 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x232.google.com with SMTP id b11so6626132pgn.12; Wed, 04 Oct 2017 08:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CXPSdP5pbw7jF42Vu0d/t7vai6oI2A1BY2XOg2c3XRc=; b=uHhgRryS5uF001W7f1u4cZAB0+wHpB+1ic9r1Sjn6xaxHdrpxFbG9+oPmLTfamiBAZ Qa8hSaz1GJfazlugwyxmFTlUb70NyqWWqJ82LOqOiC1FGnQi9N64p4J3pB25i3LEQlz2 qGmf6HIIyerVRjqwj0xwuN591xiN+Xpe+/AEFXkr8knsmz1MMa0nywTALTo0j2LTK/0f lh8DKUHQPVHxW96OX5SOjX9ym6EpbyxV9VjjMbpR4wLXmKMkFqtfOMTtVmdTJHOaSE5K Ui/xZ+/QX7u4o55DOCaKLRO1qSSa1MbXuNuhq+Y8zB1Tp62MB8RfVJ46ABBa7BK2xCi4 RGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CXPSdP5pbw7jF42Vu0d/t7vai6oI2A1BY2XOg2c3XRc=; b=DMZm68vIAJxrVJfxDLEuDYo2F/Lq3StwmSmWFc9cw7daPur8DmURBcJzblcXyWEHdH fRuTr3W+Iw3OVKmpazblFSsEfx+jDzAZ9Fxadx5YKSp60BPMNwEudBDxdaBo0YSsNrI3 cuYZl8rDIOG94aJ4JJu8nVbTZa73IFREHmGbJ52aWuCiizP8mrBE9zDZBlpLY7vBnitG oeOk2gnG5mTrDwkLxjlC6c9JLGsaMutF9802jfckQ3NIvgad77RqYrrqcuw1rDqbaKDA EsP4d/T+Gg+UXrCtiRtpZm+4wmttG9O0RixNnNIYMGFk4V8htbWTgcHD6o2P8SRPVqpR AhXA== X-Gm-Message-State: AMCzsaU7CcVbnfUnL8uVyUlbz6En3bNYTJiSYI0DqmrN2XbsVur0X5eS mPbjS58qR8S7S4rcWaP/blV+RK71 X-Google-Smtp-Source: AOwi7QCqslFYwQRyN90kepYAhF3se5e0p4ygir5vAOqrVi7HbAedr34PF3vLux4e1sJqOzgCHUjMcw== X-Received: by 10.98.4.67 with SMTP id 64mr8251217pfe.103.1507129656169; Wed, 04 Oct 2017 08:07:36 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 5sm6998802pfe.128.2017.10.04.08.07.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 08:07:35 -0700 (PDT) Content-Type: text/plain; charset=cp932 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r324257 - head/usr.sbin/mountd From: Ngie Cooper X-Mailer: iPhone Mail (15A402) In-Reply-To: <201710040843.v948huhc028834@repo.freebsd.org> Date: Wed, 4 Oct 2017 08:07:29 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201710040843.v948huhc028834@repo.freebsd.org> To: Emmanuel Vadot X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 15:07:37 -0000 > On Oct 4, 2017, at 01:43, Emmanuel Vadot wrote: >=20 > Author: manu > Date: Wed Oct 4 08:43:56 2017 > New Revision: 324257 > URL: https://svnweb.freebsd.org/changeset/base/324257 >=20 > Log: > mountd: Convert exportlist to SLIST >=20 > Use SLIST from sys/queue.h instead of homebrew linked list for the export= list. >=20 > Reviewed by: bapt, rmacklem > MFC after: 1 week > Sponsored by: Gandi.net > Differential Revision: https://reviews.freebsd.org/D12502 >=20 > Modified: > head/usr.sbin/mountd/mountd.c ... > - ep2 =3D exphead; > - epp =3D &exphead; > + SLIST_INSERT_HEAD(&exphead, ep, entries); >=20 > - /* > - * Insert in the list in alphabetical order. > - */ > - while (ep2 && strcmp(ep2->ex_fsdir, ep->ex_fsdir) < 0) { > - epp =3D &ep2->ex_next; > - ep2 =3D ep2->ex_next; > - } > - if (ep2) > - ep->ex_next =3D ep2; > - *epp =3D ep; > ep->ex_flag |=3D EX_LINKED; The new code isn=81ft functionally equivalent to the old code: the mount= list is no longer sorted on insert. Is that intentional? Thanks, -Ngie=