From nobody Wed May 20 19:37:54 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLMJg6vl1z6fJPN for ; Wed, 20 May 2026 19:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLMJg06ckz3Tp6 for ; Wed, 20 May 2026 19:37:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ewvrjwga303OxWYVFRzcQHP2D1maL4rVfo8q2/VAgxQ=; b=ntMIAdJQ8NEu5fr0Qnvt0Qciz9hFdJFWNnmCkQiwHooOa/5qqUzYphacwKRgIQsc1dqtJD qclyIPH8LXyheUFP2E9rcon8zMdWvpPaEr8NNrJInln9ErU5E6m326hFPCBuTMuGFxlvC9 yBqugZu/HRHw2mOXl7Ik8cCHbbx95CJ6Mk+FFl9gIuqRdBumeyu6yZ9us+Gv+8hh4GL9ay OXeTui1ZD2t3xEHbXHc0et28Olmp9W6Ne8FQ/1reM0ERmlU6CPBnwZ8GTPPsoxqhGrxyQK /g35oyt5wmtPb1+waTfvYL2soAJnvS5em321BsCxrskSN4gcwUVOiHS3kr497g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779305875; a=rsa-sha256; cv=none; b=uSSDYeXwBiw4/bmbXMj+Xp2fsWFMdnp++nnouy2YBrvnXOUBlumPRYKhxMXd8Wea4zzarU cj+d4A5rnDgkdnVqdj9xDek4/m9imf0rJDNyALL52R12LVDFcgVn7xUanSxhwTkDqcZA9Q 4+nfu/95jL75Ht4p1Bcysf2Pgw6jeRZuh6UpGY74wGT8aPoFaEDmySYd0QmwMmRmg+IWZX gLDjGKKBSNd3iyE/H6GOuqZv/gvjxr73oMzs0wHJp6jgRtQzn/bG+xb+R+gPWJwHue2jEc YY7XuEmbwXI/OkObOoAmPG3feVZ8tswFq8lu7iMur/yYvmq49OtGg1sGVcq2eA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779305875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ewvrjwga303OxWYVFRzcQHP2D1maL4rVfo8q2/VAgxQ=; b=m/dyYiUK7Y9JasZYJNtfT0g7ZMDGKPv7SSIFn7rVrPlzqxoEs/01t+FnbQnMmSTYHudsUK PTQxoKMEzFJvBL5Yj7NXGZ4H7JucSlVi8S5sHQKsfsn6jtwyLvY2WXhP/W4hfnvc99TX/P odS6zEpndE/W9QHfpS2t1mDDFxsoOfo9C4TxiskEB4j/oOPnPeh9ZPEh7kyupIVuppXDhq eaxxFjVX04bM52qox5GyGu/TJmONjdG01Uv18Lkhj+nd47/Ltwun8+aq4NY+3IlLc8mEGp GNVsJ/NVBnWDEFMs9L1ueFv7BSvrsCrobOjh1BBdr19/o6L1OxgXNkEfHN8eiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLMJf6nWgz1Dbv for ; Wed, 20 May 2026 19:37:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 388bf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 20 May 2026 19:37:54 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav From: Mark Johnston Subject: git: 8eb0bbbd2e46 - stable/14 - setcred: Fix buffer overflow List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8eb0bbbd2e4681dd6dc4b8d0e894438d6d4deedb Auto-Submitted: auto-generated Date: Wed, 20 May 2026 19:37:54 +0000 Message-Id: <6a0e0d92.388bf.305dfb8c@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=8eb0bbbd2e4681dd6dc4b8d0e894438d6d4deedb commit 8eb0bbbd2e4681dd6dc4b8d0e894438d6d4deedb Author: Dag-Erling Smørgrav AuthorDate: 2026-05-07 08:06:35 +0000 Commit: Mark Johnston CommitDate: 2026-05-20 19:37:14 +0000 setcred: Fix buffer overflow Since groups is a pointer to a pointer to an array of gid_t, we should use sizeof(**groups) or sizeof(gid_t) when calculating how much to allocate and copy in. We were using sizeof(*groups) instead, which meant that on 64-bit platforms, we would allocate and copy in twice as much as we should. Unfortunately, in the smallgroups case, we copy into a preallocated buffer which has the correct size, which means that if sc_supp_groups_nb >= CRED_SMALLGROUPS_NB / 2, we overflow smallgroups. This is a direct commit to stable/14. Approved by: so Security: FreeBSD-SA-26:18.setcred Reported by: Ryan of Calif.io Fixes: ddb3eb4efe55 ("New setcred() system call and associated MAC hooks") --- sys/kern/kern_prot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 246413a54903..e2accd7f7729 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -527,10 +527,10 @@ kern_setcred_copyin_supp_groups(struct setcred *const wcred, */ *groups = wcred->sc_supp_groups_nb < CRED_SMALLGROUPS_NB ? smallgroups : malloc((wcred->sc_supp_groups_nb + 1) * - sizeof(*groups), M_TEMP, M_WAITOK); + sizeof(gid_t), M_TEMP, M_WAITOK); error = copyin(wcred->sc_supp_groups, *groups + 1, - wcred->sc_supp_groups_nb * sizeof(*groups)); + wcred->sc_supp_groups_nb * sizeof(gid_t)); if (error != 0) return (error); wcred->sc_supp_groups = *groups + 1;