From owner-freebsd-net@FreeBSD.ORG Tue Aug 18 21:49:58 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12CDC106568D; Tue, 18 Aug 2009 21:49:58 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.25]) by mx1.freebsd.org (Postfix) with ESMTP id 892298FC52; Tue, 18 Aug 2009 21:49:57 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 3so1317104qwe.7 for ; Tue, 18 Aug 2009 14:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=dROb6XgKCn8igHZENjsePND0XdXC8QbaNULH8hzgpfo=; b=uLBsPbva/jUFS7tgiwQNF8xLskQG3ne7LZB+b+CUl64PFYtuDf+4g4MVyN6coXjHso g/mM2s3NdwRnVW5Z22YoSyF/HnOc5sknVaqSiUnr9nlDKa3mt4tZRtJhLahtmbi12kys f8cuZbXcd1i6kQPZiObn2GcRbtxQ5OhrHn8EU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=HM8Rb9i5Uh5QUCJufnJoaw2h55MhviKFpIfuo6dSWGyb9GlC9pn9wMschREYwL4cqO zc39RvskJ1ssQfDbb5szcm5N4W81j7c9kgYYZucfiq7pvlrxot4tMszNMM2m01Qb2jYq ciQk0ZQ/sR3q5/IVApbj+2CqTSVOblC9jK+Q4= Received: by 10.224.36.142 with SMTP id t14mr5961412qad.17.1250632196494; Tue, 18 Aug 2009 14:49:56 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 8sm1893828qwj.6.2009.08.18.14.49.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 18 Aug 2009 14:49:55 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Tue, 18 Aug 2009 14:49:14 -0700 From: Pyun YongHyeon Date: Tue, 18 Aug 2009 14:49:14 -0700 To: Xin LI Message-ID: <20090818214914.GC15025@michelle.cdnetworks.com> References: <5D267A3F22FD854F8F48B3D2B523819339EC3813D2@IRVEXCHCCR01.corp.ad.broadcom.com> <692150.91493.qm@web63906.mail.re1.yahoo.com> <2a41acea0908060905n69edf1dfkbf993d9f8a4edf37@mail.gmail.com> <4A8B1729.8070503@delphij.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8B1729.8070503@delphij.net> User-Agent: Mutt/1.4.2.3i Cc: Barney Cordoba , David Christensen , "d@delphij.net" , "freebsd-net@freebsd.org" , Jack Vogel , Jack F Vogel , yongari@freebsd.org, Julian Elischer Subject: Re: [PATCH] Fix for e1000 (em/igb) NOARP issue [Was Re: em(4): sending ARP regardless of NOARP flag] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2009 21:49:58 -0000 On Tue, Aug 18, 2009 at 02:03:37PM -0700, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, Jack, > > I have looked into the code history and found that sys/dev/em/if_em.c,v > 1.119 has introduced the arp_ifinit() call in order to fix the problem > that if_em won't send ARP when IP address is changed. > > I think we can further improve it as attached, say, only do it when > IFF_NOARP is not set. This should have no effect for usual > configuration but fix the problem when NOARP is the desired behavior. > That change was introduced by me. I guess the root cause of the problem was long initialization time of hardware which in turn resulted in unbearable boot time when multiple-alias addresses are assigned to em(4). I don't remember details,though. Since we're in the release cycle, the change you suggested would be quick fix for 8.0. I think em(4)/igb(4) should remove SIOCSIFADDR handling in driver which is layering violation.