From owner-svn-ports-all@FreeBSD.ORG  Mon Sep 15 16:05:47 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8928688E;
 Mon, 15 Sep 2014 16:05:47 +0000 (UTC)
Received: from mail-vc0-x234.google.com (mail-vc0-x234.google.com
 [IPv6:2607:f8b0:400c:c03::234])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 105AE94B;
 Mon, 15 Sep 2014 16:05:46 +0000 (UTC)
Received: by mail-vc0-f180.google.com with SMTP id hq11so3640163vcb.11
 for <multiple recipients>; Mon, 15 Sep 2014 09:05:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=t8GuRJGPcnp0d8UK1GM2Mwd+UlPeClppteEGPCOpofI=;
 b=POGI87b1BTiaZlzTfs3LnVHF+BFik/gRwJyopt/9dKaPuegXXdG4SoUClDioMqRB8O
 BBRElUpQPhV1KL/skYvZ7iCVZRoA+BXXUy0sRkLaRP5AkVWbY7n5f7Oj4vxxVPWfEuGL
 sVg1ER1VaTZMJdh/ORIYShMxY3jz7ynZ8t/ROZd3VBt8RYpYSsK/Y0SrhevxdcZwwYoV
 oLLvsYyU0gf0WdKr9ZKuc2z3SexxwzGv0JsslPwejqB+U2iOXUbXEdv6D1Db9OFDZ10h
 U+Eb9vjcH1w28eJ1IohRFkuSfN1bB8+7J2Nr2AwhquSp8M/ZXc8vWEyM9gPnF4EiQX5u
 gUlQ==
MIME-Version: 1.0
X-Received: by 10.220.17.145 with SMTP id s17mr1374011vca.77.1410797145991;
 Mon, 15 Sep 2014 09:05:45 -0700 (PDT)
Sender: bsdkaffee@gmail.com
Received: by 10.220.153.19 with HTTP; Mon, 15 Sep 2014 09:05:45 -0700 (PDT)
In-Reply-To: <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org>
References: <201409150227.s8F2ReuH083121@svn.freebsd.org>
 <CAJE75NE1p_mf4xHADQgoeKnmk_E7Wej9pfTsGJnPsJOj4PHWcw@mail.gmail.com>
 <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org>
Date: Mon, 15 Sep 2014 12:05:45 -0400
X-Google-Sender-Auth: 3a-tDbEbJEv2VTobRTHE8qfE-Lw
Message-ID: <CAJE75NEfS2=iExysLF_oPFtkQ1tE3GOZXu-rwN4-6i3wGtnhCw@mail.gmail.com>
Subject: Re: svn commit: r368241 - in head/sysutils: . jadm jadm/files
From: "Jason E. Hale" <jhale@freebsd.org>
To: Adam Weinberger <adamw@adamw.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 ports-committers <ports-committers@freebsd.org>, jadm <jadm@dachev.info>,
 "Vanilla I. Shu" <vanilla@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Sep 2014 16:05:47 -0000

On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger <adamw@adamw.org> wrote:
> On 15 Sep, 2014, at 3:50, Jason E. Hale <jhale@FreeBSD.org> wrote:
>
>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu <vanilla@freebsd.org> wrote:
>>>
>>> +BUILD_DEPENDS= ${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko \
>>> +               ${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces \
>>> +               ${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate \
>>> +               ${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress
>>
>> This is a deprecated style of depending on other Python ports.
>> Format should be:
>> BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}paramiko>=0:${PORTSDIR}/security/py-paramiko
>
> I had no idea that format was deprecated. Perhaps an example could be added to the PHB or Uses/python.mk?
>
I'm sure the Python section of the PHB could use some attention.  It
still references the old USE_PYTHON and
bsd.python.mk instead of USES=python and Uses/python.mk among other things.

The format I mentioned is the one I have seen in most Python and Perl
ports, however, Uses/python.mk has a mix
of both styles. I guess "deprecated" was a little strong, that's more
of an official word.  "Not so common" might be
more appropriate.  To me, it looks cleaner and allows for version
checking.  Even still, ${PYTHON_SITELIBDIR}
would be preferable to ${PYTHON_LIBDIR}/site-packages.