Date: Sat, 14 Mar 2009 22:32:15 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Peter Holm <pho@freebsd.org> Cc: Yoshihiro Ota <ota@j.email.ne.jp>, freebsd-fs@freebsd.org, Attilio Rao <attilio@freebsd.org> Subject: Re: kern/132597: [tmpfs] [panic] tmpfs-related panic while interrupting a port build on tmpfs WRKDIR Message-ID: <20090314203215.GA41617@deviant.kiev.zoral.com.ua> In-Reply-To: <20090314102135.GA93077@x2.osted.lan> References: <200903140450.n2E4o3to011990@freefall.freebsd.org> <20090314102135.GA93077@x2.osted.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
--SBADSSFwlTeCdIwN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 14, 2009 at 11:21:35AM +0100, Peter Holm wrote: > On Sat, Mar 14, 2009 at 04:50:03AM +0000, Yoshihiro Ota wrote: > > The following reply was made to PR kern/132597; it has been noted by GN= ATS. > >=20 > > From: Yoshihiro Ota <ota@j.email.ne.jp> > > To: bug-followup@FreeBSD.org > > Cc: bf2006a@yahoo.com > > Subject: Re: kern/132597: [tmpfs] [panic] tmpfs-related panic while > > interrupting a port build on tmpfs WRKDIR > > Date: Sat, 14 Mar 2009 00:42:58 -0400 > >=20 > > Which ports were you compiling when panic happened? > > =20 > > Hiro >=20 > The panic in this PR looks a lot like the one I reported to attilio@ >=20 > http://people.freebsd.org/~pho/stress/log/attilio022.txt >=20 > It was just regular FS load that provoked it. It seems to be quite clean what is going on there. In fact, there are two issues: First is the usual problem of DOTDOT lookup that shall be fixed in style of vn_vget_ino() by busying mp before unlocking dvp. Second one is the reason for the panic. The tmpfs vnode is unlocked, and then corresponding tmpfs _node_ is passed to the tmpfs_alloc_vp(). Since the vnode may be reclaimed after the unlock, passed node might become freed. Then, the tmpfs_alloc_vp() would operate on the freed memory. --SBADSSFwlTeCdIwN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkm8FE4ACgkQC3+MBN1Mb4ibWgCfSRjRwMyPFQOYko+oOO/1Z5C0 N80AoNyatttOuDKTJJ4lkd2zqh+QdH5z =caAy -----END PGP SIGNATURE----- --SBADSSFwlTeCdIwN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090314203215.GA41617>