Date: Mon, 10 Aug 2015 23:42:51 +0200 From: Ed Schouten <ed@nuxi.nl> To: Xin LI <delphij@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286601 - head/usr.bin/patch Message-ID: <CABh_MKmhBC%2BKqn6Xxwe4Q7C_pkUkN9Fn__MLqfQ_O-0ie=%2BPEA@mail.gmail.com> In-Reply-To: <201508102131.t7ALVo5J050735@repo.freebsd.org> References: <201508102131.t7ALVo5J050735@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Xin,
Something I forgot to mention in my previous email:
2015-08-10 23:31 GMT+02:00 Xin LI <delphij@freebsd.org>:
> + argp[0] = strdup(RCSDIFF);
> + argp[1] = strdup(filename);
> + argp[0] = strdup(CHECKOUT);
> + argp[1] = strdup("-l");
> + argp[2] = strdup(filename);
While we're at it, should we also add "--" before the filename, or can
we be sure in this context that they don't start with a dash?
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKmhBC%2BKqn6Xxwe4Q7C_pkUkN9Fn__MLqfQ_O-0ie=%2BPEA>