From owner-svn-src-head@freebsd.org  Mon Aug 10 21:42:57 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2A1699E7BA
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Mon, 10 Aug 2015 21:42:57 +0000 (UTC) (envelope-from ed@nuxi.nl)
Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com
 [209.85.214.169])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A54EF7A1
 for <svn-src-head@freebsd.org>; Mon, 10 Aug 2015 21:42:57 +0000 (UTC)
 (envelope-from ed@nuxi.nl)
Received: by obbfr1 with SMTP id fr1so97348059obb.1
 for <svn-src-head@freebsd.org>; Mon, 10 Aug 2015 14:42:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=Zq9WR8L/TMLjaJqVw55Pjm2BrdYmuaSnh1ew0oNy7+s=;
 b=lTWUrLLrmsvb9f7ultkvem9QjbyvW4qypMHARGLksZn0wPIXp+De6nhB2+VdvKmE7k
 Quyshnwmwbs7cpqK1Gf1jIhM31k3gHF1PhsWUshRpF3NTQhDKPyLWg+eJGu5yMwn1wRd
 4OqMFR7/IszWTsZJI+qHyzQLxgQFdDdMMQws7yKBaXGuteTjeQDhchCITTgXiBHjMnmM
 BJE7OVxPJEf16VV+UUDbt3JOYZbwyHW9G3kFSblvEaisqq81/Hcn4+1Mj4LJdyBjVnJD
 JVCdgNEX5cWXhxeN7gpbFe3q4KRzEhfE42bGKE66hAn2NzP62IbANa9LvBHi7f49LBY6
 InfA==
X-Gm-Message-State: ALoCoQlU4k/OAMs8vZHePdU7X2dTB9x2MGubyClaN92zkWOI66FpT6KVzyF1dnlNjQ7VR8PmIA/k
MIME-Version: 1.0
X-Received: by 10.60.98.211 with SMTP id ek19mr7849046oeb.78.1439242971500;
 Mon, 10 Aug 2015 14:42:51 -0700 (PDT)
Received: by 10.76.50.84 with HTTP; Mon, 10 Aug 2015 14:42:51 -0700 (PDT)
X-Originating-IP: [84.27.222.46]
In-Reply-To: <201508102131.t7ALVo5J050735@repo.freebsd.org>
References: <201508102131.t7ALVo5J050735@repo.freebsd.org>
Date: Mon, 10 Aug 2015 23:42:51 +0200
Message-ID: <CABh_MKmhBC+Kqn6Xxwe4Q7C_pkUkN9Fn__MLqfQ_O-0ie=+PEA@mail.gmail.com>
Subject: Re: svn commit: r286601 - head/usr.bin/patch
From: Ed Schouten <ed@nuxi.nl>
To: Xin LI <delphij@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2015 21:42:57 -0000

Hi Xin,

Something I forgot to mention in my previous email:

2015-08-10 23:31 GMT+02:00 Xin LI <delphij@freebsd.org>:
> +                               argp[0] = strdup(RCSDIFF);
> +                               argp[1] = strdup(filename);

> +                       argp[0] = strdup(CHECKOUT);
> +                       argp[1] = strdup("-l");
> +                       argp[2] = strdup(filename);

While we're at it, should we also add "--" before the filename, or can
we be sure in this context that they don't start with a dash?

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717