From owner-cvs-src@FreeBSD.ORG Thu Dec 9 22:55:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4439516A4CE; Thu, 9 Dec 2004 22:55:41 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 164A043D54; Thu, 9 Dec 2004 22:55:41 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 8548C7A403; Thu, 9 Dec 2004 14:55:40 -0800 (PST) Message-ID: <41B8D7EC.4070803@elischer.org> Date: Thu, 09 Dec 2004 14:55:40 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Sam Leffler References: <200412091641.iB9GflnD067866@repoman.freebsd.org> <20041209174457.GA82542@freefall.freebsd.org> <41B893D3.59939DEA@freebsd.org> <41B8BF81.2000701@errno.com> <20041209212512.GA946@cell.sick.ru> <41B8CAE1.6040703@errno.com> In-Reply-To: <41B8CAE1.6040703@errno.com> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: cvs-src@FreeBSD.org cc: "Christian S.J. Peron" cc: cvs-all@FreeBSD.org cc: Gleb Smirnoff Subject: Re: cvs commit: src/sys/netinet ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2004 22:55:41 -0000 > >> >> I'd like to remind you that in this thread you were against removal >> of the very similar check before doing tag lookup: >> >> http://freebsd.rambler.ru/bsdmail/freebsd-current_2004/msg22234.html > > > True, but there are differences. The post you cite was about vlans > and checking every packet that passes through a driver. That case was > significantly more performance critical than yours. The path to this change is also on every IP packet when there are any filters present. Filterring rate can be as important as forwarding rate..