From owner-svn-ports-all@FreeBSD.ORG Sun Aug 10 16:44:16 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 4AE95FDB; Sun, 10 Aug 2014 16:44:16 +0000 (UTC) Date: Sun, 10 Aug 2014 16:44:16 +0000 From: Alexey Dokuchaev To: Max Brazhnikov Subject: Re: svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke... Message-ID: <20140810164416.GA43983@FreeBSD.org> References: <53e7336d.2c4d.2257f090@svn.freebsd.org> <20140810095516.GA35955@FreeBSD.org> <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Marcus von Appen , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Aug 2014 16:44:16 -0000 On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote: > On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote: > > On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote: > > > New Revision: 364518 > > > URL: http://svnweb.freebsd.org/changeset/ports/364518 > > > QAT: https://qat.redports.org/buildarchive/r364518/ > > > > > > -USES= pkgconfig > > > +USES= pkgconfig python:2 > > > USE_GNOME= atk > > > -USE_PYTHON= 2 > > > -USE_PYDISTUTILS=yes > > > -PYDISTUTILS_AUTOPLIST= yes > > > +PYTHON_FEATURES=autoplist distutils > > > > Yuck, this PYTHON_FEATURES knob is ugly. Why not follow Perl's example > > instead (USES=perl and USE_PERL)? It both makes more sense and shorter. > > ugly or not, it's a matter of taste. [...] Not really. It is also 1) inconsistent with USE_PERL, and 2) is overly long knob name (breaks indentation). ./danfe P.S. I'm wondering about these "a matter of taste" reasons. Are you guys really don't see the ugliness when it's there? Why defending it when it can/should be just fixed?