From owner-svn-src-head@freebsd.org Tue Dec 17 04:42:38 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4702B1DB7D3; Tue, 17 Dec 2019 04:42:38 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cQVP5xs1z3KBt; Tue, 17 Dec 2019 04:42:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id h4gpimwZhkqGXh4griQ1F5; Mon, 16 Dec 2019 21:42:34 -0700 X-Authority-Analysis: v=2.3 cv=c/jVvi1l c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=pxVhFHJ0LMsA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=_G6RStKDQ7vUjxhPL5gA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id B803EDB2; Mon, 16 Dec 2019 20:42:30 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id xBH4gU6q063780; Mon, 16 Dec 2019 20:42:30 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id xBH4gUOg063777; Mon, 16 Dec 2019 20:42:30 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201912170442.xBH4gUOg063777@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Pedro F. Giffuni" cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355828 - head/sys/sys In-reply-to: <201912162355.xBGNtUq6078840@repo.freebsd.org> References: <201912162355.xBGNtUq6078840@repo.freebsd.org> Comments: In-reply-to "Pedro F. Giffuni" message dated "Mon, 16 Dec 2019 23:55:30 +0000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 16 Dec 2019 20:42:30 -0800 X-CMAE-Envelope: MS4wfM3IjWBGR6DVrQeMpGdq5YM3vE+Buu7fMEZ6FWsjJQiLRu/MVvNGfPefvkijA+/742US6GGf21wW26p9rHm0Liqga9WW4VHzB6YiQwvIVjvPQcUp/eE6 IQayKM9llz87LO7HqPW9kshwy6AEhsm9T7bRPABKRwXXiYu1CW3SToYZ7OJvB3A4jc4O7d0+kSxTObphjdmyy4WDX/YEcq2cBqFiDoPMu1zw5yVhJPBoVccP KUbi6E9ONid4HVjgKARsc9+Wyj0qGz++uB0P8QV2u70hiiQ1S2qnuqwpPyPm3Sgj X-Rspamd-Queue-Id: 47cQVP5xs1z3KBt X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 04:42:38 -0000 In message <201912162355.xBGNtUq6078840@repo.freebsd.org>, "Pedro F. Giffuni" w rites: > Author: pfg > Date: Mon Dec 16 23:55:30 2019 > New Revision: 355828 > URL: https://svnweb.freebsd.org/changeset/base/355828 > > Log: > Double the size of ARG_MAX on LP64 platforms. > > As modern software keeps growing in size, we get requests to update the > value of ARG_MAX in order to link the resulting object files. Other OSs > have much higher values but Increasiong ARG_MAX has a multiplied effect on > KVA, so just bumping this value is dangerous in some archs like ARM32 that > can exhaust KVA rather easily. > > While it would be better to have a unique value for all archs, other OSs > (Illumos in partidular) can have different ARG_MAX limits depending on the > platform, For now we want to be really conservative so we are avoidng > the change on ILP32 and in the alternative case we only double it since tha > t > seems to work well enough for recent Code Aster. > > I was planning to bump the _FreeBSD_version but it was bumped recently > (r355798) so we can reuse the 1300068 value for this change. This doesn't seem right. Each bump should be for a distinct change and documented as such. Also, it's not like we're saving any build time anyway. sys/syslimits.h will cause a substantial portion to be rebuilt anyway. > > PR: 241710 > MFC after: 5 days > > Modified: > head/sys/sys/syslimits.h > > Modified: head/sys/sys/syslimits.h > ============================================================================= > = > --- head/sys/sys/syslimits.h Mon Dec 16 23:08:09 2019 (r355827) > +++ head/sys/sys/syslimits.h Mon Dec 16 23:55:30 2019 (r355828) > @@ -48,7 +48,11 @@ > * Do not add any new variables here. (See the comment at the end of > * the file for why.) > */ > -#define ARG_MAX 262144 /* max bytes for an exec functi > on */ > +#ifndef __ILP32__ > +#define ARG_MAX (2 * 256 * 1024) /* max bytes for an exec functi > on */ > +#else > +#define ARG_MAX (256 * 1024) /* max bytes for KVA-starved ar > chs */ > +#endif > #ifndef CHILD_MAX > #define CHILD_MAX 40 /* max simultaneous processes * > / > #endif > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.