From owner-svn-src-head@freebsd.org Tue Jul 3 20:12:58 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B18F1022481; Tue, 3 Jul 2018 20:12:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DA3DE96483; Tue, 3 Jul 2018 20:12:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id aRfOfAH92ogHjaRfPfvuka; Tue, 03 Jul 2018 14:12:51 -0600 X-Authority-Analysis: v=2.3 cv=Sre+FsG0 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=R9QF1RCXAYgA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=VxmjJ2MpAAAA:8 a=FmRi0MEEDUOsP-fuaEAA:9 a=CjuIK1q_8ugA:10 a=TLyZHkqU5i0A:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=7gXAzLPJhVmCkEl4_tsf:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id EF0837B2; Tue, 3 Jul 2018 13:12:49 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w63KCX6F019885; Tue, 3 Jul 2018 13:12:33 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w63KCXHg019870; Tue, 3 Jul 2018 13:12:33 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201807032012.w63KCXHg019870@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Bryan Drewery cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335908 - head/sys/conf In-Reply-To: Message from Bryan Drewery of "Tue, 03 Jul 2018 13:09:34 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Jul 2018 13:12:33 -0700 X-CMAE-Envelope: MS4wfPT4zq4GpaHZ5Ar0hetQcD6FlYOUsR/6bULC6t27n4rj+IncY1wklgluQoOzQHgjcFMvV4TcsNOxTa9UqY35/M+hJ/pKUhVT/LiFoBBnPB/eRRP9LAJv 98DP6tk6NRrE78psfEaUTHGS3qI6exVcMFqAUQpksKo37Yw1f/93SpHqU5dCpijUkUxfQtIMOqf8j5gQ+JW63Ketn6890c479PnijynPxkTfE1agCYnxS+ex J6T9NsR4YA4JFAPmiYoGRVidrLM+eV6bBaf/X4RJPaKiMXSkuyyMV5rNT4x99qyO X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 20:12:58 -0000 In message , Bryan Drewery wr ites: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --5LBlvAHx6wd2MBY6ZJGLCKfNccUC2f3P7 > Content-Type: multipart/mixed; boundary="FxkUanNxVoyIpem522qWwd6g1GQCAsxqA"; > protected-headers="v1" > From: Bryan Drewery > To: Cy Schubert > Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, > svn-src-head@freebsd.org > Message-ID: > Subject: Re: svn commit: r335908 - head/sys/conf > References: <201807032006.w63K6c3E069211@slippy.cwsent.com> > In-Reply-To: <201807032006.w63K6c3E069211@slippy.cwsent.com> > > --FxkUanNxVoyIpem522qWwd6g1GQCAsxqA > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > On 7/3/2018 1:06 PM, Cy Schubert wrote: > > In message <201807032003.w63K3JD3071764@repo.freebsd.org>, Bryan=20 > > Drewery writes > > : > >> Author: bdrewery > >> Date: Tue Jul 3 20:03:19 2018 > >> New Revision: 335908 > >> URL: https://svnweb.freebsd.org/changeset/base/335908 > >> > >> Log: > >> Fix r335906+r335907 to not pass multiple source files to genoffset_t= > est.o t > >> arget. > >> =20 > >> This is working around a bug with the FAST_DEPEND logic with custom = > targets > >> that use .ALLSRC. > >> =20 > >> Reported by: mmacy > >> > >> Modified: > >> head/sys/conf/kern.post.mk > >> > >> Modified: head/sys/conf/kern.post.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D > >> =3D > >> --- head/sys/conf/kern.post.mk Tue Jul 3 19:24:52 2018 (r33590 > >> 7) > >> +++ head/sys/conf/kern.post.mk Tue Jul 3 20:03:19 2018 (r33590 > >> 8) > >> @@ -195,8 +195,8 @@ genoffset.o: $S/kern/genoffset.c > >> # is to exercise the CTASSERT that checks that the offsets in the off= > set.inc > >> # _lite struct(s) match those in the original(s).=20 > >> genoffset_test.o: $S/kern/genoffset.c offset.inc > >> - ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}= > \ > >> - -o ${.TARGET} > >> + ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST \ > >> + $S/kern/genoffset.c -o ${.TARGET} > >=20 > > This still won't build because of -c and -o. > > -c is just a hint to the compiler to not run the linker. It's fine. We > even have this pattern used in share/mk/bsd.suffixes.mk. I sent my second reply to you before you sent your first one to me. We're good now. Sorry for the spam. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.