From nobody Tue Jul 14 19:26:29 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h08SC0w60z6lBGy for ; Tue, 14 Jul 2026 19:26:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h08SB5rJdz3vFv for ; Tue, 14 Jul 2026 19:26:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784057194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qOHfrKgoq1rWFceoch2Ko+Zm/sZ9oB0NUsZ0MHN+jwk=; b=mYE2wMh9jTtbvOhyVwDP2i8qGkq+oIZiuGDnpp7FmFrTKgftXzEiRvkNNWYtZ83pcgdI2+ PTqUs0EW7bvaqrZIGk6slBFL6Q2ZaDYcoelNSlaPxsVcaYMgggbJQlyyW1qAw0aYy0q9jf l0URQMtDgG1w4vNiBaiSEEmZQSBBoEeArUFnodPx70dqWzlLzK8jlFv5l+Q6GelscfF6W8 m3AGXSFKp1Mnz9KkXX0xBSZAB17hG5OT5nCgwvmXfISkxoD1P6knauYGkVcFPNuapXfTMp IRDNVg47Bbf+sY4hQEy68mhjE3py27CJLEw3Us4E+6Ho2QuWUBkboz/61ni/vg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784057194; a=rsa-sha256; cv=none; b=GsgeeFkeDWDL5Om4v17hUQy/0bUOchF90gBWvym9OuJq98jqQ/CJE4bklrFAl3cmq79SQ/ Xfnd61fi9KvizAwndyUOr+LVJYEmV4gDa3+wa8INVlMFfXx1nEXPnPgV7gLMfT4pEtN5b3 sqeF9p6vWmItg1L9DdfzWzTl4m3rdA8cq9bEu12U7XdiirJp83jaCaEdiWdOy8YahrtExZ Jpzezm5TtA23SaMlSMrFddjm9aKx2Q5xDtsVqX9zmwIgg+SSflNaKfJaSXD5LwbOV3qBBx oHp6kXO4Orm2J3SXnl1TpROawXzVSQZ8xbLfdHFZg36aEr8OsuZ7nZku97m3ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784057194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qOHfrKgoq1rWFceoch2Ko+Zm/sZ9oB0NUsZ0MHN+jwk=; b=B1WLrVSL4fKA+h/YB4Zr+hWrxsqSXU6KW1GSaFlAwSs4MfAi866JnQ/wc6hVWSbbUfU/R8 U9p7aEukkO0axmonDbzzLaNNO5+R2i97+YiM1ms1952G9E6YL96xqGfK02xFOsM9kYu1pX OqwuejmCOkn29MwD2ROjfRYDbkYdvFB0pd8P8Osx1p+rCMF06SCyKXQG5SF3MQKzjjp0ES uUijpWfO3vKsqopj8xnDRED8KMMarYLBbER+k4tKPQoZkAHWJY8HzO/8uOXyvIrcuPbvAS evFaLUmeKN1yrkIyWGylifJdThrgfRgqt5Rk77tvgWJ/x/Rt+g4g5UUwolfMGA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h08SB3mqszxtV for ; Tue, 14 Jul 2026 19:26:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31972 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 14 Jul 2026 19:26:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ariel Ehrenberg From: Konstantin Belousov Subject: git: 40cc9de950f7 - main - mlx5ib: use the eventfd_ctx API for DEVX event subscriptions List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 40cc9de950f7e6ba2049467fa05c46b9161f49a5 Auto-Submitted: auto-generated Date: Tue, 14 Jul 2026 19:26:29 +0000 Message-Id: <6a568d65.31972.2d83a62d@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=40cc9de950f7e6ba2049467fa05c46b9161f49a5 commit 40cc9de950f7e6ba2049467fa05c46b9161f49a5 Author: Ariel Ehrenberg AuthorDate: 2026-06-15 08:27:56 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-14 19:25:48 +0000 mlx5ib: use the eventfd_ctx API for DEVX event subscriptions The DEVX_SUBSCRIBE_EVENT redirect path resolved the user's eventfd with fdget(), which on FreeBSD only finds LinuxKPI files. rdma-core creates the eventfd with the native FreeBSD eventfd(2), so the lookup failed and subscription returned EBADF; the delivery side likewise assumed a LinuxKPI-pollable file. Use the LinuxKPI eventfd_ctx API instead: eventfd_ctx_fdget() resolves the native eventfd, eventfd_signal() notifies it, and eventfd_ctx_put() releases it. DEVX async events can then be delivered through a redirect eventfd. Reviewed by: kib Sponsored by: Nvidia networking MFC after: 1 month --- sys/dev/mlx5/mlx5_ib/mlx5_ib_devx.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/sys/dev/mlx5/mlx5_ib/mlx5_ib_devx.c b/sys/dev/mlx5/mlx5_ib/mlx5_ib_devx.c index 12ce45d8c1e7..5f4aa160cfcf 100644 --- a/sys/dev/mlx5/mlx5_ib/mlx5_ib_devx.c +++ b/sys/dev/mlx5/mlx5_ib/mlx5_ib_devx.c @@ -44,6 +44,7 @@ #include #include #include +#include #include #include @@ -102,7 +103,7 @@ struct devx_event_subscription { struct rcu_head rcu; u64 cookie; struct devx_async_event_file *ev_file; - struct fd eventfd; + struct eventfd_ctx *eventfd; }; struct devx_async_event_file { @@ -2016,10 +2017,11 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_SUBSCRIBE_EVENT)( uverbs_uobject_get(&ev_file->uobj); if (use_eventfd) { event_sub->eventfd = - fdget(redirect_fd); + eventfd_ctx_fdget(redirect_fd); - if (event_sub->eventfd.file == NULL) { - err = -EBADF; + if (IS_ERR(event_sub->eventfd)) { + err = PTR_ERR(event_sub->eventfd); + event_sub->eventfd = NULL; goto err; } } @@ -2070,8 +2072,8 @@ err: obj, obj_id); - if (event_sub->eventfd.file) - fdput(event_sub->eventfd); + if (event_sub->eventfd) + eventfd_ctx_put(event_sub->eventfd); uverbs_uobject_put(&event_sub->ev_file->uobj); kfree(event_sub); } @@ -2338,8 +2340,8 @@ static void dispatch_event_fd(struct list_head *fd_list, struct devx_event_subscription *item; list_for_each_entry_rcu(item, fd_list, xa_list) { - if (item->eventfd.file != NULL) - linux_poll_wakeup(item->eventfd.file); + if (item->eventfd != NULL) + eventfd_signal(item->eventfd); else deliver_event(item, data); } @@ -2629,8 +2631,8 @@ static void devx_free_subscription(struct rcu_head *rcu) struct devx_event_subscription *event_sub = container_of(rcu, struct devx_event_subscription, rcu); - if (event_sub->eventfd.file) - fdput(event_sub->eventfd); + if (event_sub->eventfd) + eventfd_ctx_put(event_sub->eventfd); uverbs_uobject_put(&event_sub->ev_file->uobj); kfree(event_sub); }