From owner-svn-src-all@freebsd.org Wed Mar 30 17:22:37 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A591CAE3944; Wed, 30 Mar 2016 17:22:37 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 83C0E1389; Wed, 30 Mar 2016 17:22:37 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from zeppelin.tachypleus.net (75-101-50-44.static.sonic.net [75.101.50.44]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id u2UHMTlN001446 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 30 Mar 2016 10:22:29 -0700 Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Zbigniew Bodek References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <56FBE3D6.9050205@freebsd.org> Cc: Ed Maste , Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Nathan Whitehorn Message-ID: <56FC0B55.1040805@freebsd.org> Date: Wed, 30 Mar 2016 10:22:29 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: X-Sonic-CAuth: UmFuZG9tSVbJFkhhFqb4v+rd+mzIDOCLuLP7YcxjOcKbO7UqG0wTnJego1qCRRc2T1W5Rvl/lILCBqISnxYuWcBTjBANLHqJviV5/k7f3oY= X-Sonic-ID: C;vsO4+pv25RGYVcgVZbXa/Q== M;/Lb6+pv25RGYVcgVZbXa/Q== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 17:22:37 -0000 I think it should be pci aim | fdt, just like the previous line when the files lived in sys/powerpc. To conf, that evaluates as pci && (aim || fdt). -Nathan On 03/30/16 08:55, Zbigniew Bodek wrote: > > Thank you Nathan. Please check out new patch in the attachment. > > Best regards > zbb > > 2016-03-30 16:33 GMT+02:00 Nathan Whitehorn >: > > PowerPC (and SPARC) can have real OFW without FDT support. Adding > FDT to LINT is the wrong solution: rather, it should switch on fdt > | aim like the rest of the Open Firmware code. > -Nathan > > > On 03/30/16 01:54, Zbigniew Bodek wrote: >> Hello Ed, >> >> Please check out the attached patch. For powerpc we should >> compile-in ofwpci.c regardless of FDT option. >> However, it seems that LINT for powerpc does not have FDT. What >> do you thing about adding it (as can be seen in the attached >> patch)?. This would be done in a separate commit. >> >> Best regards >> zbb >> >> 2016-03-30 1:53 GMT+02:00 Ed Maste > >: >> >> On 29 March 2016 at 15:19, Zbigniew Bodek > > wrote: >> > Author: zbb >> > Date: Tue Mar 29 15:19:56 2016 >> > New Revision: 297392 >> > URL: https://svnweb.freebsd.org/changeset/base/297392 >> > >> > Log: >> > Reduce OFW PCI code duplication - involves ARM, PPC and >> SPARC64 >> >> My 'make tinderbox' build is now failing (powerpc LINT) with: >> >> linking kernel >> cpcht.o: In function `cpcht_attach': >> cpcht.c:(.text+0x17dc): undefined reference to `ofw_pci_attach' >> cpcht.o:(.data.rel+0x0): undefined reference to `ofw_pci_driver' >> grackle.o: In function `grackle_attach': >> grackle.c:(.text+0x2dc): undefined reference to `ofw_pci_attach' >> grackle.o:(.data.rel+0x0): undefined reference to >> `ofw_pci_driver' >> uninorthpci.o: In function `uninorth_attach': >> uninorthpci.c:(.text+0x68c): undefined reference to >> `ofw_pci_attach' >> uninorthpci.o:(.data.rel+0x0): undefined reference to >> `ofw_pci_driver' >> *** [kernel] Error code 1 >> _______________________________________________ >> svn-src-all@freebsd.org >> mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to >> "svn-src-all-unsubscribe@freebsd.org >> " >> >> > >