From owner-svn-src-head@FreeBSD.ORG Thu Apr 25 08:43:45 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 4F2E0636; Thu, 25 Apr 2013 08:43:45 +0000 (UTC) (envelope-from ronald-freebsd8@klop.yi.org) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.78]) by mx1.freebsd.org (Postfix) with ESMTP id DA8571638; Thu, 25 Apr 2013 08:43:44 +0000 (UTC) Received: from smtp.greenhost.nl ([213.108.104.138]) by smarthost1.greenhost.nl with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1UVHW1-0008R7-Dz; Thu, 25 Apr 2013 10:26:53 +0200 Received: from [81.21.138.17] (helo=ronaldradial.versatec.local) by smtp.greenhost.nl with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1UVHVz-0003Nf-RC; Thu, 25 Apr 2013 10:26:51 +0200 Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Alexander Motin" Subject: Re: svn commit: r249849 - in head/sys/dev: hptmv mpt References: <201304241900.r3OJ0jHL083318@svn.freebsd.org> Date: Thu, 25 Apr 2013 10:26:50 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "Ronald Klop" Message-ID: In-Reply-To: <201304241900.r3OJ0jHL083318@svn.freebsd.org> User-Agent: Opera Mail/12.15 (Win32) X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.5 X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.1 X-Scan-Signature: 2c269fdec788119c0964d98755c55204 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2013 08:43:45 -0000 Hi, Maybe I need more coffee, but I don't see a difference between the if and the else statements in the hptmv file. Regards, Ronald. On Wed, 24 Apr 2013 21:00:45 +0200, Alexander Motin wrote: > Author: mav > Date: Wed Apr 24 19:00:45 2013 > New Revision: 249849 > URL: http://svnweb.freebsd.org/changeset/base/249849 > > Log: > Move hptmv and mpt drivers shutdown a bit later to the > SHUTDOWN_PRI_LAST > stage of shutdown_post_sync. That should allow CAM to do final cache > flush > at the SHUTDOWN_PRI_DEFAULT without using polling magic. > MFC after: 3 days > > Modified: > head/sys/dev/hptmv/entry.c > head/sys/dev/mpt/mpt_pci.c > > Modified: head/sys/dev/hptmv/entry.c > ============================================================================== > --- head/sys/dev/hptmv/entry.c Wed Apr 24 18:30:32 2013 (r249848) > +++ head/sys/dev/hptmv/entry.c Wed Apr 24 19:00:45 2013 (r249849) > @@ -2605,9 +2605,11 @@ launch_worker_thread(void) > * hpt_worker_thread needs to be suspended after shutdown sync, when > fs sync finished. > */ > #if (__FreeBSD_version < 500043) > - EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc, > hptdaemonproc, SHUTDOWN_PRI_FIRST); > + EVENTHANDLER_REGISTER(shutdown_post_sync, shutdown_kproc, > hptdaemonproc, > + SHUTDOWN_PRI_LAST); > #else > - EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown, > hptdaemonproc, SHUTDOWN_PRI_FIRST); > + EVENTHANDLER_REGISTER(shutdown_post_sync, kproc_shutdown, > hptdaemonproc, > + SHUTDOWN_PRI_LAST); > #endif > } > /* > > Modified: head/sys/dev/mpt/mpt_pci.c > ============================================================================== > --- head/sys/dev/mpt/mpt_pci.c Wed Apr 24 18:30:32 2013 (r249848) > +++ head/sys/dev/mpt/mpt_pci.c Wed Apr 24 19:00:45 2013 (r249849) > @@ -563,7 +563,7 @@ mpt_pci_attach(device_t dev) > } > mpt->eh = EVENTHANDLER_REGISTER(shutdown_post_sync, mpt_pci_shutdown, > - dev, SHUTDOWN_PRI_DEFAULT); > + dev, SHUTDOWN_PRI_LAST); > if (mpt->eh == NULL) { > mpt_prt(mpt, "shutdown event registration failed\n"); > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"