From owner-freebsd-current@FreeBSD.ORG  Sun Aug 10 13:47:36 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AFC8C1065676;
	Sun, 10 Aug 2008 13:47:36 +0000 (UTC)
	(envelope-from patfbsd@davenulle.org)
Received: from smtp.lamaiziere.net (net.lamaiziere.net [91.121.44.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 75C5D8FC08;
	Sun, 10 Aug 2008 13:47:36 +0000 (UTC)
	(envelope-from patfbsd@davenulle.org)
Received: from baby-jane.lamaiziere.net (111.158.192-77.rev.gaoland.net
	[77.192.158.111])
	by smtp.lamaiziere.net (Postfix) with ESMTPA id 2ECA9633662;
	Sun, 10 Aug 2008 15:40:36 +0200 (CEST)
Received: from baby-jane-lamaiziere-net.local (localhost [127.0.0.1])
	by baby-jane.lamaiziere.net (Postfix) with ESMTP id 16255599F48;
	Sun, 10 Aug 2008 15:47:33 +0200 (CEST)
Date: Sun, 10 Aug 2008 15:47:32 +0200
From: Patrick =?ISO-8859-15?Q?Lamaizi=E8re?= <patfbsd@davenulle.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20080810154732.4f8ed1de@baby-jane-lamaiziere-net.local>
In-Reply-To: <20080809202225.GA1363@garage.freebsd.pl>
References: <20080808115152.GF89712@carrot.paeps.cx>
	<20080809180719.5415955f@baby-jane-lamaiziere-net.local>
	<20080809202225.GA1363@garage.freebsd.pl>
Organization: /dave/nulle
X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; i386-apple-darwin9.3.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8bit
Cc: current@freebsd.org
Subject: Re: Committing glxsb - any objections?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Aug 2008 13:47:36 -0000

Le Sat, 9 Aug 2008 22:22:25 +0200,
Pawel Jakub Dawidek <pjd@FreeBSD.org> a écrit :

> On Sat, Aug 09, 2008 at 06:07:19PM +0200, Patrick Lamaizi?re wrote:
> > Le Fri, 8 Aug 2008 13:51:52 +0200,
> > Philip Paeps <philip@freebsd.org> a écrit :
> > 
> > > So, I've been running with glxsb for a while now on my soekris
> > > boxes, and it looks like it actually works.  I get some pretty
> > > nice results from it too.
> > > 
> > > Does anyone have any plans to commit this?  Would anyone object
> > > if I committed it?
> > 
> > Oh, it was committed today :-)
> > 
> > I just want to thank you all.
> > Many thanks, best regards.
> 
> Could you review some further improvements?
> 
> 	http://people.freebsd.org/~pjd/patches/glxsb.patch

Cool, works fine here. Thank you.

I missed few things in style(9) (oups).

What is the recommended maximum length of one line ?

Regards.