From owner-cvs-src@FreeBSD.ORG Thu Sep 29 19:44:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECED216A41F; Thu, 29 Sep 2005 19:44:30 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9628F43D49; Thu, 29 Sep 2005 19:44:30 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.33] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j8TJiXo5012084 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 29 Sep 2005 12:44:34 -0700 Message-ID: <433C441A.8050508@root.org> Date: Thu, 29 Sep 2005 12:44:26 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <20050928192056.B7E6D16A42B@hub.freebsd.org> <200509291054.40587.jhb@FreeBSD.org> <433C291E.3050409@root.org> <200509291406.19775.jhb@FreeBSD.org> In-Reply-To: <200509291406.19775.jhb@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 19:44:31 -0000 John Baldwin wrote: > On Thursday 29 September 2005 01:49 pm, Nate Lawson wrote: > >>John Baldwin wrote: >> >>>On Wednesday 28 September 2005 04:36 pm, Nate Lawson wrote: >>> >>>>I've heard disabling apic helps T42s, otherwise they get a hard hang. >>>>It's difficult to print the driver progress while suspending because the >>>>function call stack is recursive, not iterative. For example, >>>>root_suspend -> pci_suspend -> fxp_suspend -> mii_suspend (if that >>>>exists). You'd have to add a printf in every driver and bus. A better >>>>way might be to add printf or KTR to bus_generic_suspend() to print the >>>>device name before calling its method. >>>> >>>>BTW, I'm working on committing a patch that adds KTR to acpi so we can >>>>track down issues like this although the device suspending stuff should >>>>be done separately as listed above. >>> >>>BTW, the issue with APIC on some systems is that when we use the APIC, >>>the current code doesn't end up doing suspend/resume for the ATPIC and so >>>it ends up in some random state. >> >>Ah, is a fix for that upcoming? :) > > > It's in my head. I think I need to rework the suspend/resume support in the > x86 interrupt code to instead of doing all the interrupt sources, having the > atpic and apic code register pic devices in a separate list that gets > iterated on suspend and resume. I think that makes sense since they have different programming methods. Does it make sense to separate them into different newbus devices as well, so you get proper ordering? -- Nate