From owner-svn-ports-all@FreeBSD.ORG  Tue Mar  4 22:18:58 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D133733B;
 Tue,  4 Mar 2014 22:18:58 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A5A7B261;
 Tue,  4 Mar 2014 22:18:58 +0000 (UTC)
Received: by apnoea.adamw.org (Postfix, from userid 1002)
 id 54D6811FDF7; Tue,  4 Mar 2014 17:11:03 -0500 (EST)
Date: Tue, 4 Mar 2014 17:11:03 -0500
From: Adam Weinberger <adamw@FreeBSD.org>
To: Max Brazhnikov <makc@freebsd.org>
Subject: Re: svn commit: r346968 - head/converters/libiconv
Message-ID: <20140304221103.GA77114@apnoea.adamw.org>
References: <201403032115.s23LFU07023939@svn.freebsd.org>
 <CAALwa8khAJy0-1kozwo42=M6Y+maK9Wdqx5coLMfRb65Jqx+2A@mail.gmail.com>
 <1617323.9tYKgzxRAl@mercury.ph.man.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1617323.9tYKgzxRAl@mercury.ph.man.ac.uk>
X-Editor: Vim 7.3 http://www.vim.org
X-Mailer: Mutt 1.5 http://www.mutt.org
X-Adamw: ADAMW!!!
X-URL: http://www.adamw.org
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 Antoine Brodin <antoine@freebsd.org>, Adam Weinberger <adamw@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2014 22:18:58 -0000

>> (2014/03/04 @ 0539 EST): Max Brazhnikov said, in 0.8K: <<
> On Tue, 04 Mar 2014 11:35:56 +0100 Antoine Brodin wrote:
> > On Mon, Mar 3, 2014 at 10:15 PM, Adam Weinberger <adamw@freebsd.org> wrote:
> > >   Don't unconditionally install DOCS. PORTREVISION bump
> > >   for plist change.
> > 
> > Why didn't you add DOCS to OPTIONS_DEFINE?
> > This is the policy for ports that respect the DOCS option.
> 
> Besides, there's no reason for bumping PORTREVISION:
> plist with default options is the same.
> 
>> end of "Re: svn commit: r346968 - head/converters/libiconv" from Max Brazhnikov <<

But plist changed for non-default options. From a package-building
perspective I see your point.

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org