From owner-freebsd-current@freebsd.org Mon Aug 24 08:58:34 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3EA99C145F for ; Mon, 24 Aug 2015 08:58:34 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BB9C1493 for ; Mon, 24 Aug 2015 08:58:34 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by wicja10 with SMTP id ja10so65119411wic.1 for ; Mon, 24 Aug 2015 01:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=HhS8FYZpyy2WluYUFHxU/e50yOGzYL6/Kf1osNwv/mw=; b=xXOx8t7om100/p2FKRbdhhSTyDlgcJk5Gu5bgro+5+FdWB6IfnpH1TJzxWb7OZ2ubm lSmJKQqYM9ZbaKx50AbzRcWRDtUl7UotsOqkIUkcYGTuKqnX5KEtg2zvBcObjCn5KZGj bkaYvsud0FKyT+LmnY+sx2MJ7kfy5nnBCYJYaO0fl10Gyut4rT+MEhD8g5wmGFhXukMI H/em9csQg84b5+c8twx//SywhhR7yBfhHyEVM4WWugE/xx8BX5baSW+q7k66gtk0Q1ox U/pP6nWig2cpZ8/pr7SceFut1bcCnUlfokTrRijwJg3x+EqzmnHm80UZWC8ynq+SI38h nuKA== X-Received: by 10.180.86.163 with SMTP id q3mr27744192wiz.75.1440406712808; Mon, 24 Aug 2015 01:58:32 -0700 (PDT) Received: from brick.home (adee119.neoplus.adsl.tpnet.pl. [79.184.82.119]) by smtp.gmail.com with ESMTPSA id ej5sm22130947wjd.22.2015.08.24.01.58.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2015 01:58:31 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Mon, 24 Aug 2015 10:37:00 +0200 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Larry Rosenman Cc: freebsd-current@freebsd.org Subject: Re: racct crash/Linux Emulation Message-ID: <20150824083700.GA1253@brick.home> Mail-Followup-To: Larry Rosenman , freebsd-current@freebsd.org References: <20150824012857.GA6409@borg.lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150824012857.GA6409@borg.lerctr.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 08:58:34 -0000 On 0823T2028, Larry Rosenman wrote: > got the below panio, on a linux (world community grid) process exit. > > > borg.lerctr.org dumped core - see /var/crash/vmcore.5 > > Sun Aug 23 20:14:24 CDT 2015 > > FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #46 r287028: Sat Aug 22 18:34:59 CDT 2015 root@borg.lerctr.org:/usr/obj/usr/src/sys/VT-LER amd64 > > panic: racct_sub: freeing 1 of resource 11, which is more than allocated 0 for wcgrid_fahv_vina_pr (pid 1140) Could you try the patch below? Index: sys/compat/linux/linux_fork.c =================================================================== --- sys/compat/linux/linux_fork.c (revision 287034) +++ sys/compat/linux/linux_fork.c (working copy) @@ -285,10 +285,20 @@ linux_clone_thread(struct thread *td, struct linux p = td->td_proc; +#ifdef RACCT + if (racct_enable) { + PROC_LOCK(p); + error = racct_add(p, RACCT_NTHR, 1); + PROC_UNLOCK(p); + if (error != 0) + return (EPROCLIM); + } +#endif + /* Initialize our td */ error = kern_thr_alloc(p, 0, &newtd); if (error) - return (error); + goto fail; cpu_set_upcall(newtd, td); @@ -369,6 +379,16 @@ linux_clone_thread(struct thread *td, struct linux td->td_retval[0] = newtd->td_tid; return (0); + +fail: +#ifdef RACCT + if (racct_enable) { + PROC_LOCK(p); + racct_sub(p, RACCT_NTHR, 1); + PROC_UNLOCK(p); + } +#endif + return (error); } int