From nobody Wed Apr 15 09:29:00 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwbST0XcLz6ZbD0 for ; Wed, 15 Apr 2026 09:29:13 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwbSS5grkz4PRl for ; Wed, 15 Apr 2026 09:29:12 +0000 (UTC) (envelope-from rlibby@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-79a46260385so70877087b3.3 for ; Wed, 15 Apr 2026 02:29:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776245352; x=1776850152; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VzbspL4cP++Ktdk5RQBJd18u2DonjLp/cTewYc6bQqs=; b=VXLcG8dYTb5puc/cksz6P82zSA1KyMjZcXQ+I4txX7nagXNVLHnWL3RRPrn0muUhd1 RBp7wcmYKpqVbEYtPc9PKM3Y287eoSEa1w7ioKCLbDqs/3NQM08Z3bjYOL6iSqPidClI UrSRgLXw2pbhGjHBgBh6I02jllw0YzXBFYm0FCfxnzVQeUGcO8olUD5qBxfJReKNkI12 yn6v80aMEqTo7VsvowLae7hjYOIfUl3AMEi4bF+s5nk+ydTGbVhnN3Lg4482Xtq6TuJd 00RtcdfwmKgo5Pq9VstmTT2+LSouHKcj/TM/RO8mVGDoA9V0DJbRR/tgQljoL8ArF1p8 5Gkg== X-Forwarded-Encrypted: i=1; AFNElJ+Hy5tFBGw5a4YpaqARinIbEPFSTJxMSaba09UdfJjtcifNfANZMA3tsvZEXcK9TB0YsbzBphDTAkxbie3c882h0P1uUA==@freebsd.org X-Gm-Message-State: AOJu0Ywgit96XtD0KyBd0MnEfjJskMR599JmDgxF0Tbmd2kDghqHov4T AYg1wztKp/9XKM5lnqs/fFq8PVmX1SYi6+iGgtOTapHomsKDsKnIFk9eaoAPLQ== X-Gm-Gg: AeBDieuJ7YF4gIEUK3Mi8cOBAvpA2bbhxuKjKAkXOoMw5QpV84l4Xg+pOxGF76Bmj3B byygf4yzT9iDuIZY41VctQgDLn1d7m0nsswd+kyuxPOXfTwyNxCyAiyMwHaXoYFDeJaHuJ2odzv /DNxcAgfoN2sR1FOUZ2YcKbw3rPeKK6zRTJ26pZ0VjqQHk7czl3Cap9Fg+6ShfKrKGTjRRQi9e9 1i/IO8Bgzjp6vKCCxLoqBtyau4aJWqyXBXPBrDVBUIPnjq/HNdQB7WsTotJwGMPsLztBI61ThhF GRQCeIMq9fFud/16zdP5JDn8L+Mlqf4IiHlLPuPSkh9eeVRg8vopkgAtvmOxfY/CsaLRuQAto0Y qJUTwkSIV208hrrXkA1CYdwR4dLnvajZ7TZu2UYuukwciOx+VO2Dn21W2Kw5nwgzOnIElC+erPm Ogq8n+vD1s81wrGnmCk7KorRSW9b6S9s3CxMiGVzyOasBYy9q+luBmsPlYKfBsdt2jHkLe X-Received: by 2002:a05:690c:dd4:b0:79b:dd37:69b4 with SMTP id 00721157ae682-7af6f8094ddmr205469847b3.13.1776245351910; Wed, 15 Apr 2026 02:29:11 -0700 (PDT) Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com. [74.125.224.47]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b7662147e1sm6212937b3.1.2026.04.15.02.29.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 02:29:11 -0700 (PDT) Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-651b0eb2564so4248542d50.3 for ; Wed, 15 Apr 2026 02:29:11 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ9adorF6fK7bYSzB3jgeWYIVbOYbl/MK3hz8LYh1x7YkBa/A6aZK6GZp1PmSoVxvgRlGqLolJv8rdK9uYe+2UtxLIsu9Q==@freebsd.org X-Received: by 2002:a05:690e:134c:b0:651:b7e2:6835 with SMTP id 956f58d0204a3-651b7e268f5mr14220448d50.35.1776245351276; Wed, 15 Apr 2026 02:29:11 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <69df4dc9.18e73.533e828@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Wed, 15 Apr 2026 02:29:00 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AQROBzD91QOFGW37l2Lr1t1IOEUQLUu3dQTDgfct01SVQPTZ-1Hod_ZIjz4-pho Message-ID: Subject: Re: git: 00dccc3164c6 - main - sys/time: appease gcc -Wtype-limits To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4fwbSS5grkz4PRl X-Spamd-Bar: ---- On Wed, Apr 15, 2026 at 2:00=E2=80=AFAM Konstantin Belousov wrote: > > On Wed, Apr 15, 2026 at 08:35:21AM +0000, Ryan Libby wrote: > > The branch main has been updated by rlibby: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D00dccc3164c6dff38350a1ba= eeea7238acf2efc3 > > > > commit 00dccc3164c6dff38350a1baeeea7238acf2efc3 > > Author: Ryan Libby > > AuthorDate: 2026-04-15 08:08:37 +0000 > > Commit: Ryan Libby > > CommitDate: 2026-04-15 08:08:37 +0000 > > > > sys/time: appease gcc -Wtype-limits > > > > In environments where time_t is 32 bits, including the 32-bit libra= ry > > build on amd64, the overflow being tested for cannot happen, and gc= c > > complains with -Wtype-limits, causing the gcc build to fail. Work > > around this by ifdef'ing out the saturation code on i386. > > > > Reviewed by: imp, jfree > > Discussed with: markj > > Fixes: e3799530b3ba ("sys/time: Add saturating sbt conversions") > > Differential Revision: https://reviews.freebsd.org/D56369 > > --- > > sys/sys/time.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sys/sys/time.h b/sys/sys/time.h > > index 707565b6a6f1..6f18d8bd844d 100644 > > --- a/sys/sys/time.h > > +++ b/sys/sys/time.h > > @@ -355,10 +355,12 @@ tstosbt(struct timespec _ts) > > static __inline sbintime_t > > tstosbt_sat(struct timespec _ts) > > { > > +#ifndef __i386__ > > if (_ts.tv_sec > SBT_MAX >> 32) > > return (SBT_MAX); > > if (_ts.tv_sec < -(SBT_MAX >> 32) - 1) > > return (-SBT_MAX - 1); > > +#endif > > return (tstosbt(_ts)); > > } > > > > @@ -382,10 +384,12 @@ tvtosbt(struct timeval _tv) > > static __inline sbintime_t > > tvtosbt_sat(struct timeval _tv) > > { > > +#ifndef __i386__ > > if (_tv.tv_sec > SBT_MAX >> 32) > > return (SBT_MAX); > > if (_tv.tv_sec < -(SBT_MAX >> 32) - 1) > > return (-SBT_MAX - 1); > > +#endif > > return (tvtosbt(_tv)); > > } > > I dislike the direct tests for the arch. Could we add some define like > __SIZEOF_TIME_T and put the code under > #ifdef __SIZEOF_TIME_T >=3D 8 instead of __i386__? Sure, that would work, if you don't mind the wider patch and added definiti= ons. I put up this diff for review: https://reviews.freebsd.org/D56401 Ryan