From owner-cvs-all@FreeBSD.ORG  Mon Aug  7 17:14:18 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D2DF916A4DE;
	Mon,  7 Aug 2006 17:14:18 +0000 (UTC)
	(envelope-from prvs=julian=36751bcc1@elischer.org)
Received: from a50.ironport.com (a50.ironport.com [63.251.108.112])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3CE5E43D49;
	Mon,  7 Aug 2006 17:14:18 +0000 (GMT)
	(envelope-from prvs=julian=36751bcc1@elischer.org)
Received: from unknown (HELO [10.251.18.229]) ([10.251.18.229])
	by a50.ironport.com with ESMTP; 07 Aug 2006 10:14:18 -0700
Message-ID: <44D774E9.4010309@elischer.org>
Date: Mon, 07 Aug 2006 10:14:17 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.13) Gecko/20060414
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <200608051358.k75DwpYr070713@repoman.freebsd.org>
	<20060807092251.GS96644@FreeBSD.org>
In-Reply-To: <20060807092251.GS96644@FreeBSD.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, Stefan Farfeleder <stefanf@FreeBSD.org>,
	cvs-all@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ipfw ipfw2.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Aug 2006 17:14:18 -0000

Gleb Smirnoff wrote:

>On Sat, Aug 05, 2006 at 01:58:50PM +0000, Stefan Farfeleder wrote:
>S> stefanf     2006-08-05 13:58:50 UTC
>S> 
>S>   FreeBSD src repository
>S> 
>S>   Modified files:
>S>     sbin/ipfw            ipfw2.c 
>S>   Log:
>S>   Use the SLIST_NEXT macro instead of sle_next.
>
>Uhhrm. This code is a hack really, and using bad style emphasizes
>that. It says: BEWARE! We use queue.h internals for our own dirty
>needs. So I left "sle_next" here intentionally.
>
>The hack was made here to keep ABI compatibility, and make the later
>changes mergeable to RELENG_6.
>
>Let it be SLIST_NEXT() now. Anyway there is a plan of major rewrite
>of API and ipfw(8) itself.
>
>  
>
great.. I have been in ipfw(2) the last week and have some sugestions for
increasing its efficiency.. especially the code that times out dynamic 
rules.