Date: Tue, 27 Nov 2012 10:56:19 -0500 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, "Jason E. Hale" <jhale@freebsd.org>, Philippe Audeoud <jadawin@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307827 - in head/net-mgmt: . p5-BigIP-iControl Message-ID: <CAF6rxgmr1ceKrhujptEpRkH1QYK%2BY40sJf70rF%2BxkVvvsE2B-Q@mail.gmail.com> In-Reply-To: <20121127155338.GB72381@FreeBSD.org> References: <201211270903.qAR93QpW027051@svn.freebsd.org> <4501883.lPumvzqanH@mocha.verizon.net> <CAF6rxg=sLDt9g4bookekOfMWw_h-CEgWWKUZ39JYYaL9FQVgBg@mail.gmail.com> <20121127155338.GB72381@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 November 2012 10:53, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Tue, Nov 27, 2012 at 10:49:56AM -0500, Eitan Adler wrote:
>> On 27 November 2012 10:37, Jason E. Hale <jhale@freebsd.org> wrote:
>> >> +
>> >> +RUN_DEPENDS= p5-SOAP-Lite>=0:${PORTSDIR}/net/p5-SOAP-Lite \
>> >> + p5-MIME-Base64>=0:${PORTSDIR}/converters/p5-MIME-Base64
>> >> +BUILD_DEPENDS= ${RUN_DEPENDS}
>> >
>> > It would be better to use BUILD_DEPENDS:= ${RUN_DEPENDS}
>> > to avoid duplicate perl build dependency.
>>
>> Please see r289563:
>> According to portmgr: Explicit duplication > := > =
>
> This is very bogus. I think it should be reconsidered. := suits perfectly
> for the purpose, and we should not neglect this nifty make(1) feature.
I believe the concern was that build only depends would be added with
no consideration as to if they should also be run depends. Note that
I still have no personal opinion on this, I am just explaining why
that commit message says what it does.
--
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmr1ceKrhujptEpRkH1QYK%2BY40sJf70rF%2BxkVvvsE2B-Q>