From owner-svn-ports-all@FreeBSD.ORG Tue Nov 27 15:56:52 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A75E899A for ; Tue, 27 Nov 2012 15:56:52 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id EE3638FC15 for ; Tue, 27 Nov 2012 15:56:51 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so9439380lbb.13 for ; Tue, 27 Nov 2012 07:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=fynW92i2VSJOGXQmqvheI59Af08X1cRKVtP9BB4DVpA=; b=j5kJUuvNjDnLRj2YtKlww/AC4Cxs5NF2H7rlaa/UfZycd+txpSj3p1ukeSmzatRV+r zq8wNtwEsxGDh601BlnuOMLAwy1UTeLh4fl4WTgseYqK1jwSgoVzLXfwOSi1MsqZtmU6 mj2s2xA2MipHXiN71dbw6MheY3QE0EW6dTZi0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=fynW92i2VSJOGXQmqvheI59Af08X1cRKVtP9BB4DVpA=; b=F8LsVSgdpTpvDTkrkrNI6UqFWKSsr2M7RpzfnvaNN/hiGb+xunB1aKNkPQXc3FbCp5 hkbMkwY6gAtFF/cSsOX6VqV97MyPy+9peq7mKVIJxbZFdu7a4SXUBP6rgYtRrrYzyCbu mBuK5gUY/OMWsCpobgDUcLjxFSqCgV2SggLgwaBJXH1b95m3xdlOrj12pX/2wixIQzVK tjgXHqzJbQUVDQuM0pCmFgO4SbnY4Sy3IlkXi4+5nxMDnYr7ijTzl1GPYxyOwDRX4WQC X3+Vly+c3MPtE1snemJ3fXLE20fRJLTICj92oCOnMfWU/go1aBUzq+e5Mx4gy5TOfFf8 GGdg== Received: by 10.112.38.228 with SMTP id j4mr6812723lbk.87.1354031810448; Tue, 27 Nov 2012 07:56:50 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Tue, 27 Nov 2012 07:56:19 -0800 (PST) In-Reply-To: <20121127155338.GB72381@FreeBSD.org> References: <201211270903.qAR93QpW027051@svn.freebsd.org> <4501883.lPumvzqanH@mocha.verizon.net> <20121127155338.GB72381@FreeBSD.org> From: Eitan Adler Date: Tue, 27 Nov 2012 10:56:19 -0500 X-Google-Sender-Auth: 7K_3jV76TmMlSD2-wtdvGNW9G50 Message-ID: Subject: Re: svn commit: r307827 - in head/net-mgmt: . p5-BigIP-iControl To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQn/wJAd8CrRlUDvuRnZMdxa7+K7PX/a6ljx73IAr6TdvqpLlhbslbtQI2oJ3GlpvHq7YLo+ Cc: svn-ports-head@freebsd.org, "Jason E. Hale" , Philippe Audeoud , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 15:56:52 -0000 On 27 November 2012 10:53, Alexey Dokuchaev wrote: > On Tue, Nov 27, 2012 at 10:49:56AM -0500, Eitan Adler wrote: >> On 27 November 2012 10:37, Jason E. Hale wrote: >> >> + >> >> +RUN_DEPENDS= p5-SOAP-Lite>=0:${PORTSDIR}/net/p5-SOAP-Lite \ >> >> + p5-MIME-Base64>=0:${PORTSDIR}/converters/p5-MIME-Base64 >> >> +BUILD_DEPENDS= ${RUN_DEPENDS} >> > >> > It would be better to use BUILD_DEPENDS:= ${RUN_DEPENDS} >> > to avoid duplicate perl build dependency. >> >> Please see r289563: >> According to portmgr: Explicit duplication > := > = > > This is very bogus. I think it should be reconsidered. := suits perfectly > for the purpose, and we should not neglect this nifty make(1) feature. I believe the concern was that build only depends would be added with no consideration as to if they should also be run depends. Note that I still have no personal opinion on this, I am just explaining why that commit message says what it does. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams