From owner-freebsd-current@FreeBSD.ORG  Fri Aug  3 19:39:56 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D7B31065670
	for <current@freebsd.org>; Fri,  3 Aug 2012 19:39:56 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id D65C08FC18
	for <current@freebsd.org>; Fri,  3 Aug 2012 19:39:55 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 29B8BB992;
	Fri,  3 Aug 2012 15:39:55 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Kevin Oberman <kob6558@gmail.com>
Date: Fri, 3 Aug 2012 15:39:47 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; )
References: <201208031418.57941.jhb@freebsd.org>
	<CAN6yY1t824WcE3J_9+G_VK7QNWr=yuxLdBLMyB_wFZB-OaqrTA@mail.gmail.com>
In-Reply-To: <CAN6yY1t824WcE3J_9+G_VK7QNWr=yuxLdBLMyB_wFZB-OaqrTA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201208031539.47735.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Fri, 03 Aug 2012 15:39:55 -0400 (EDT)
Cc: current@freebsd.org
Subject: Re: [PATCH] Add locking to twe(4) so it no longer uses Giant
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2012 19:39:56 -0000

On Friday, August 03, 2012 2:56:00 pm Kevin Oberman wrote:
> I'll try to find time to try it later today, but I'm in the middle of
> budget wrangling and I can't make any promises.
> 
> Before I try, will these patches apply to the twe driver in
> 9.1-PRERELEASE? My system with twe was updated to RELENG_9 on July 18.
> I really don't have time to install current right now.

I believe the patches should apply fine on 8 and 9.  If you use it on 8 or 9
please make sure to enable INVARIANTS and INVARIANT_SUPPORT at least for
initial testing.  Thanks!

> -- 
> R. Kevin Oberman, Network Engineer
> E-mail: kob6558@gmail.com
> 
> On Fri, Aug 3, 2012 at 11:18 AM, John Baldwin <jhb@freebsd.org> wrote:
> > We only have a few storage drivers left that use Giant and twe(4) is one of
> > them.  I don't have any hardware to test with, however.  I have verified the
> > patch compiles, but I'd appreciate it if some folks with twe(4) hardware could
> > test it.
> >
> > The patch is at http://www.FreeBSD.org/~jhb/patches/twe_locking.patch
> 

-- 
John Baldwin