From owner-svn-src-head@FreeBSD.ORG  Sun Mar 27 17:22:31 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id DB08D106564A;
	Sun, 27 Mar 2011 17:22:31 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 8A44D15542F;
	Sun, 27 Mar 2011 17:22:31 +0000 (UTC)
Message-ID: <4D8F7257.50207@FreeBSD.org>
Date: Sun, 27 Mar 2011 10:22:31 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.9.2.15) Gecko/20110326 Thunderbird/3.1.9
MIME-Version: 1.0
To: Josh Paetzel <jpaetzel@FreeBSD.org>
References: <201103271657.p2RGvs2m063692@svn.freebsd.org>
In-Reply-To: <201103271657.p2RGvs2m063692@svn.freebsd.org>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, kib@FreeBSD.org
Subject: Re: svn commit: r220059 - head/usr.sbin/pc-sysinstall/backend
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Mar 2011 17:22:32 -0000

On 03/27/2011 09:57, Josh Paetzel wrote:
> Log:
>    Fix a syntax error in a little-used function.

Since this is unique vs. all the other changes, IMO it should have been 
a separate commit. It doesn't hurt anything to split things up into 
multiple commits, and often helps make things more understandable down 
the road.

>    Replace expr with $(())
>    Replace tests for ! -z with -n

Good. :)

>    Replace grep>  /dev/null with grep -q
>    Consolidate export statements with variable assignment

These 2 make the code slightly less portable, but in this case I don't 
think that's a problem at all.

>    Replace "$?" = "0" with $? -eq 0 in tests

Excellent!


hth,

Doug

-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/