From owner-freebsd-fs@FreeBSD.ORG Mon Sep 3 08:53:59 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CBE59106564A for ; Mon, 3 Sep 2012 08:53:59 +0000 (UTC) (envelope-from bryan@shatow.net) Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92]) by mx1.freebsd.org (Postfix) with ESMTP id 55B0E8FC08 for ; Mon, 3 Sep 2012 08:53:59 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sweb; b=wU4lKU M/Bw7L6sSTLZgpTqxHFs4+29K695f+OOUy6CxikuFGOEir682pEAWd9A+gKrn7j9 Pf58S7kvCAiop0Zaz5V7oYv3xxhCIg5Ph4mEEWTrj/PehTr9RJxXQ/fn+g3A4a+u nzL53jbBf1PtKHKDGgdT4dSTgTPO3qYpZ73qY= DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=shatow.net; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sweb; bh=CIemKve1L+CW zPUBPi4wfyyJvgf/6aYak5MciJySTJI=; b=tbA17r9QIJCi1sHMdVfIV8RQunT7 7caeEdDxbN6yiImihuMDlBy6wBU+OepvnQCgg2eEif7cjFdchzr8zHC3TXWKcyCX REejIYneGb54ZmnaIgPhhr5H0kS2vGMPozYTsPe3fm+SfnAj4nR/funZV78xyD+x 4JsqHeogKwhQfqo= Received: (qmail 62634 invoked from network); 3 Sep 2012 03:53:57 -0500 Received: from unknown (HELO ?10.10.0.115?) (bryan@shatow.net@10.10.0.115) by sweb.xzibition.com with ESMTPA; 3 Sep 2012 03:53:57 -0500 Message-ID: <50447024.9020209@shatow.net> Date: Mon, 03 Sep 2012 03:53:56 -0500 From: Bryan Drewery User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Fabian Keil References: <504428EB.4020702@shatow.net> <504430F9.8000105@shatow.net> <5044482D.90602@shatow.net> <5044556C.3020208@shatow.net> <20120903104525.531e5d3d@fabiankeil.de> In-Reply-To: <20120903104525.531e5d3d@fabiankeil.de> X-Enigmail-Version: 1.4.4 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: Panic in zfs_freebsd_getattr -> zfs_fuid_table_load - avl_find() succeeded inside avl_add() [ACL, 9.1-PRERELEASE] [SOLVED] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 08:53:59 -0000 On 9/3/2012 3:45 AM, Fabian Keil wrote: > Bryan Drewery wrote: > >> On 9/3/2012 1:03 AM, Bryan Drewery wrote: >>> On 9/2/2012 11:24 PM, Bryan Drewery wrote: >>>>> On Sep 2, 2012 8:51 PM, "Bryan Drewery" >>>> > wrote: >>>>> >>>>> Running 9.1-PRERELEASE currently. >>>>> >>>>> Just set this server up, imported the pool from OpenIndiana 151 I >>>>> believe it was. >>>>> >>>>> When I access (simply `ls`) certain files/directories, the system >>>>> panics. These files have ACL properties set on them from the Solaris >>>>> system. >>>>> >>>>> This system has 32gb of ram and only 8gb swap setup, so I do not >>>>> currently have a kernel core dump. It's also practically a production >>>>> machine, so I do not have much leeway in testing on it. > > For the space issue setting debug.minidump and vfs.zfs.zio.exclude_metadata > could help (if they aren't set already). Thanks, will look at those. > >> I've solved this and now have a working system. >> >> r230454 [1] fixes this. It had a MFC of 1 week but never made it to >> 9-STABLE. >> >> Please MFC this! >> >> OTOH, the change looks wrong, but I don't know enough to say that for >> certain. >> >> >> Why change kd_name to size 1, and then use strcpy(). Looks like an easy >> overflow. >> >> [1] http://lists.freebsd.org/pipermail/svn-src-head/2012-January/033707.html > > Note that the size of the allocated buffer is sizeof(*kd) + strlen(domain), > not just sizeof(*kd). I saw and realized this after sending. > > Fabian > -- Regards, Bryan Drewery bdrewery@freenode/EFNet