Date: Mon, 03 Sep 2012 03:53:56 -0500 From: Bryan Drewery <bryan@shatow.net> To: Fabian Keil <freebsd-listen@fabiankeil.de> Cc: freebsd-fs@freebsd.org Subject: Re: Panic in zfs_freebsd_getattr -> zfs_fuid_table_load - avl_find() succeeded inside avl_add() [ACL, 9.1-PRERELEASE] [SOLVED] Message-ID: <50447024.9020209@shatow.net> In-Reply-To: <20120903104525.531e5d3d@fabiankeil.de> References: <504428EB.4020702@shatow.net> <CAOjFWZ7rtAG=fEKgEp9e3T69ENzCe6ZzyMzpWQbd7wtSC3938A@mail.gmail.com> <504430F9.8000105@shatow.net> <5044482D.90602@shatow.net> <5044556C.3020208@shatow.net> <20120903104525.531e5d3d@fabiankeil.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/3/2012 3:45 AM, Fabian Keil wrote: > Bryan Drewery <bryan@shatow.net> wrote: > >> On 9/3/2012 1:03 AM, Bryan Drewery wrote: >>> On 9/2/2012 11:24 PM, Bryan Drewery wrote: >>>>> On Sep 2, 2012 8:51 PM, "Bryan Drewery" <bryan@shatow.net >>>>> <mailto:bryan@shatow.net>> wrote: >>>>> >>>>> Running 9.1-PRERELEASE currently. >>>>> >>>>> Just set this server up, imported the pool from OpenIndiana 151 I >>>>> believe it was. >>>>> >>>>> When I access (simply `ls`) certain files/directories, the system >>>>> panics. These files have ACL properties set on them from the Solaris >>>>> system. >>>>> >>>>> This system has 32gb of ram and only 8gb swap setup, so I do not >>>>> currently have a kernel core dump. It's also practically a production >>>>> machine, so I do not have much leeway in testing on it. > > For the space issue setting debug.minidump and vfs.zfs.zio.exclude_metadata > could help (if they aren't set already). Thanks, will look at those. > >> I've solved this and now have a working system. >> >> r230454 [1] fixes this. It had a MFC of 1 week but never made it to >> 9-STABLE. >> >> Please MFC this! >> >> OTOH, the change looks wrong, but I don't know enough to say that for >> certain. >> >> >> Why change kd_name to size 1, and then use strcpy(). Looks like an easy >> overflow. >> >> [1] http://lists.freebsd.org/pipermail/svn-src-head/2012-January/033707.html > > Note that the size of the allocated buffer is sizeof(*kd) + strlen(domain), > not just sizeof(*kd). I saw and realized this after sending. > > Fabian > -- Regards, Bryan Drewery bdrewery@freenode/EFNet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50447024.9020209>