From owner-svn-src-head@freebsd.org Tue Oct 22 18:05:08 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61B4E160FD9; Tue, 22 Oct 2019 18:05:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46yLyD1mV6z46Jy; Tue, 22 Oct 2019 18:05:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f68.google.com with SMTP id 53so3400860otv.4; Tue, 22 Oct 2019 11:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=wnMBDC0NZzsABxMqO+U1/zz9s0ugwLwDFWrJNppFlpE=; b=gLSqcY+Yx405M8gsRDNHcdCPKoi+AXC6ZfNRh0DTGy6xMPV8pZjjWaYdJHDpb14odq 53Gsi1s76Pc2wk7ADiEG7mN4BEP98kYUd2WrsBJlIJqWMkzoN1wMEwUDgxx2GKGlK2QL FOIYhppAye8iA7BJh4ZHAo8Y5PDmA4lGEpOvqZ/GqLs5fFdSnrqEjcINIz4V28sLku42 mXX+rEdub4RKvqSWPaCMbHPH0yVR/BrdQJ1QD2UAr446rn1d8ZhI2X7BaA5WSTGzRDdF UmuKMsueLI+/MX0wBq1wJDm9aq9i9ELmp+7elI2tXeR4cbuBsmK+10suAfmXFTTAToE6 SzNA== X-Gm-Message-State: APjAAAVbCwoZyJOdmv7fnvEVXhWQWBbFfyabmtM1DP4sU1EtLSHUrxSh xtDTZswiPUvxU0eIoJJc5rLSHLmm X-Google-Smtp-Source: APXvYqxksP9p8+AL9cPk3fIb5zdTKtZu1mPvzzDkNsBNjxiVlFA+IvcyZ4q7o5tPnAbBAEXIredO0A== X-Received: by 2002:a9d:3df7:: with SMTP id l110mr3612429otc.245.1571767506224; Tue, 22 Oct 2019 11:05:06 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id s194sm4903944oie.19.2019.10.22.11.05.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 11:05:05 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id s22so14999256otr.6; Tue, 22 Oct 2019 11:05:05 -0700 (PDT) X-Received: by 2002:a05:6830:1609:: with SMTP id g9mr3557848otr.175.1571767505426; Tue, 22 Oct 2019 11:05:05 -0700 (PDT) MIME-Version: 1.0 References: <201910161321.x9GDL2ee021543@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Tue, 22 Oct 2019 11:04:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r353640 - head/sys/kern To: Alan Somers Cc: Andrew Turner , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46yLyD1mV6z46Jy X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.989,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 18:05:08 -0000 Theoretically the information should be here, but it's still locked: https://admbugs.freebsd.org/show_bug.cgi?id=651 . On Tue, Oct 22, 2019 at 8:51 AM Alan Somers wrote: > > On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: >> >> Author: andrew >> Date: Wed Oct 16 13:21:01 2019 >> New Revision: 353640 >> URL: https://svnweb.freebsd.org/changeset/base/353640 >> >> Log: >> Stop leaking information from the kernel through timespec >> >> The timespec struct holds a seconds value in a time_t and a nanoseconds >> value in a long. On most architectures these are the same size, however >> on 32-bit architectures other than i386 time_t is 8 bytes and long is >> 4 bytes. >> >> Most ABIs will then pad a struct holding an 8 byte and 4 byte value to >> 16 bytes with 4 bytes of padding. When copying one of these structs the >> compiler is free to copy the padding if it wishes. >> >> In this case the padding may contain kernel data that is then leaked to >> userspace. Fix this by copying the timespec elements rather than the >> entire struct. >> >> This doesn't affect Tier-1 architectures so no SA is expected. >> >> admbugs: 651 >> MFC after: 1 week >> Sponsored by: DARPA, AFRL > > > Good catch. Might I ask how you found it, or who reported it?