From owner-dev-commits-ports-main@freebsd.org  Tue Sep 14 11:51:23 2021
Return-Path: <owner-dev-commits-ports-main@freebsd.org>
Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4C4EE667A6B;
 Tue, 14 Sep 2021 11:51:23 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4H81s71NB4z3rKw;
 Tue, 14 Sep 2021 11:51:23 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
 t=1631620283;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=qmM7AVzMwWMzCCDSsApY7BxI0KczDk+m3Jx0pH10vvc=;
 b=VwZORzsn5TT+TD/Qlo+/026i4yHPp0QtH3cxQoi5v9EOvW4hnge/DXESjyAtVT9rnNGWbO
 q34Woc1/Uzenv0EKwhNqVIeC534Lkg7owzB+M5XI6222nqKGWrHBPTMujAusOYIYQGBz/7
 QvkWU9XH5LpwK8g+rCl9qQ3WZWcN2tocEs4G78xM45LbiOzrXHXVtyRY5u4hnq0BvVUT8N
 tAJFz4Q21Q97yKkSxXtPgCWV/uHRTDT3E54XdEfSMcPtfSTyIFuN5dsTVrgcB/cxzacKvG
 Msot9ukFefX9AEJ1MT5g3HlMIKDpQNgdR+GelMoyPjWXfm9dSTsrSqOcHGpUSA==
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 1C11664D7; Tue, 14 Sep 2021 11:51:23 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Emmanuel Vadot <manu@FreeBSD.org>
Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
 dev-commits-ports-main@FreeBSD.org
Subject: Re: git: 4f3befc2a362 - main - ports-mgmt/pkg-devel: Add an option
 for building with sanitizer
References: <202109141010.18EAA5Yb091282__26781.7482979567$1631614221$gmane$org@gitrepo.freebsd.org>
Date: Tue, 14 Sep 2021 13:51:18 +0200
In-Reply-To: <202109141010.18EAA5Yb091282__26781.7482979567$1631614221$gmane$org@gitrepo.freebsd.org>
 (Emmanuel Vadot's message of "Tue, 14 Sep 2021 10:10:05 GMT")
Message-ID: <bl4v-ml3d-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1631620283;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=qmM7AVzMwWMzCCDSsApY7BxI0KczDk+m3Jx0pH10vvc=;
 b=tjIm68YQQ3UqwZkDHHH6DD6+bvmNk0yalsb9EaN1Ss3R/N/w2sl4KII64D1zOGqDhDMdRm
 xWsKMFY2Nqh/wdZqhpZNK6PGpYUJx2dZQPjCPlHEz1Gd77ZyxKImLIjuPwZOeM+BF0eh6+
 IAbzeSag05Ncd7IumSpbFEumXDmyxNd3wY1jXkj+SBWK3mKrvy9HVt6B8qKfw/in/rY/y0
 1UgX8ZFEm6uH2XzOXOSX1UnTL4YiJMWsCQXZK6cQ4k49QKwPh2nUYINRaM30aZRqgiafKu
 VrprQgQoEusDSyUqlhbfMIr459AiRzppc37AKtvc3htH37i1wZiaS4Arj1ut8g==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1631620283; a=rsa-sha256; cv=none;
 b=EBIEqcLzbmbatevqtiTvKUbUvs09lEiwiVT40/4ut8qki3KCwFGGAXeTYmvYSVHQT47IER
 q0LkpBVFauhBPG7oK4rllO+F+nOEqVNa20C1BP6N5KjVc7L3LQGQujNPbmC2flUamteHQ4
 WyZ7FzRLCb8XtVOp3Ir0VuGzRp+PJgTvvW/199VI27IC9IS/EdLiMVwGEX5XHr3MnRVCKQ
 4N/4cSGt0FH62yRJubky/f2kUs1u26CbUseBqa6X52I9gszQYNoCCfes5U1cNxhpsQWkmV
 hLTnNj+++HOWyGNB+U0P+fApv+BA1zT6StSLESN1AWAOg7bUnFZFR1s/VGh9Zw==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: dev-commits-ports-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commits to the main branch of the FreeBSD ports repository
 <dev-commits-ports-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-main/>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Help: <mailto:dev-commits-ports-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-main>, 
 <mailto:dev-commits-ports-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Sep 2021 11:51:23 -0000

Emmanuel Vadot <manu@FreeBSD.org> writes:

> -OPTIONS_DEFINE=	DOCS
> +OPTIONS_DEFINE=	DOCS SAN
> +SAN_DESC=	Enable sanitizers (ASAN and UBSAN)

FWIW, other ports use different option name:

net-p2p/c-lightning/Makefile
38:ASAN_CONFIGURE_ENABLE=		address-sanitizer
39:ASAN_DESC=                   Compile with address-sanitizer

security/snort3/Makefile
35:ADDRESSSANITIZER_DESC=	Enable address sanitizer
44:ADDRESSSANITIZER_CMAKE_BOOL=	ENABLE_ADDRESS_SANITIZER
41:THREADSANITIZER_DESC=	Enable thread sanitizer
54:THREADSANITIZER_CMAKE_BOOL=	ENABLE_THREAD_SANITIZER

>  
> +.if ${PORT_OPTIONS:MSAN}
> +CONFIGURE_ARGS+=	--with-asan --with-ubsan
> +.endif

With option helpers it can be more declarative e.g.,

SAN_CONFIGURE_WITH=	asan ubsan