From owner-freebsd-bugs@FreeBSD.ORG Sat Jan 17 10:50:13 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F30616A4CE for ; Sat, 17 Jan 2004 10:50:13 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58C5A43D48 for ; Sat, 17 Jan 2004 10:50:11 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0HIoBFR013018 for ; Sat, 17 Jan 2004 10:50:11 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0HIoB4H013015; Sat, 17 Jan 2004 10:50:11 -0800 (PST) (envelope-from gnats) Date: Sat, 17 Jan 2004 10:50:11 -0800 (PST) Message-Id: <200401171850.i0HIoB4H013015@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Ruslan Ermilov Subject: Re: misc/61322: bsd.dep.mk disallows shell generated flags in CFLAGS X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ruslan Ermilov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2004 18:50:13 -0000 The following reply was made to PR misc/61322; it has been noted by GNATS. From: Ruslan Ermilov To: "Valentin A. Alekseev" Cc: bug-followup@FreeBSD.org Subject: Re: misc/61322: bsd.dep.mk disallows shell generated flags in CFLAGS Date: Sat, 17 Jan 2004 20:42:07 +0200 --Oiv9uiLrevHtW1RS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2004 at 10:31:29AM -0800, Valentin A. Alekseev wrote: >=20 > >How-To-Repeat: > Makefile: > .. > PROG=3D xgrep > CFLAGS+=3D `xml2-config --cflags` > .. > Output of make depend: > $ make depend > rm -f .depend > mkdep -f .depend -a xgrep.c > xgrep.c:6:27: libxml/parser.h: No such file or directory > xgrep.c:7:26: libxml/xpath.h: No such file or directory > mkdep: compile failed >=20 XML2_CFLAGS!=3D xml2-config --cflags CFLAGS+=3D ${XML2_CFLAGS} > >Fix: > Here is a patch that blindly allows ones to use any shell generated > vars in CFLAGS. Maybe it would be better to replace M`* with M`*-config a= nd M*` with M--cflags`. >=20 The patch you've sent is severely damaged. Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --Oiv9uiLrevHtW1RS Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFACYH/Ukv4P6juNwoRAqSrAJ9OdZQMXmlhbuJrFVToCa+YRdJomwCfYYWz H5YusPv3iJwiRLnPmvqhkxY= =61P0 -----END PGP SIGNATURE----- --Oiv9uiLrevHtW1RS--