From owner-svn-src-head@FreeBSD.ORG Thu Oct 23 19:01:48 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F2C0106567B; Thu, 23 Oct 2008 19:01:48 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from emh03.mail.saunalahti.fi (emh03.mail.saunalahti.fi [62.142.5.109]) by mx1.freebsd.org (Postfix) with ESMTP id B8D608FC1D; Thu, 23 Oct 2008 19:01:47 +0000 (UTC) (envelope-from jh@saunalahti.fi) Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh03-2.mail.saunalahti.fi (Postfix) with SMTP id 97DA2EC661; Thu, 23 Oct 2008 21:46:26 +0300 (EEST) Received: from emh02.mail.saunalahti.fi ([62.142.5.108]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A02D3B892E1; Thu, 23 Oct 2008 21:46:26 +0300 Received: from ws64.jh.dy.fi (a91-153-122-179.elisa-laajakaista.fi [91.153.122.179]) by emh02.mail.saunalahti.fi (Postfix) with SMTP id D37832BD52; Thu, 23 Oct 2008 21:46:21 +0300 (EEST) Date: Thu, 23 Oct 2008 21:46:21 +0300 From: Jaakko Heinonen To: Dag-Erling Smorgrav Message-ID: <20081023184621.GA32081@ws64.jh.dy.fi> References: <200810231553.m9NFrqQj060598@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810231553.m9NFrqQj060598@svn.freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-Antivirus: VAMS Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev/... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2008 19:01:48 -0000 Hi, On 2008-10-23, Dag-Erling Smorgrav wrote: > Log: > Retire the MALLOC and FREE macros. They are an abomination unto style(9). This change introduces some bad formatting. Many statements would now fit to 80 columns and don't need to be wrapped. > - MALLOC(softc, struct targ_softc *, sizeof(*softc), M_TARG, > + softc = malloc(sizeof(*softc), M_TARG, > M_WAITOK | M_ZERO); . > - MALLOC(descr, struct targ_cmd_descr *, sizeof(*descr), M_TARG, > + descr = malloc(sizeof(*descr), M_TARG, > M_WAITOK); . > - MALLOC(de, struct device_element *, sizeof(*de), > + de = malloc(sizeof(*de), > M_LINUX, M_WAITOK); There are also places with unnecessary white space: > + cl->cl_rsc = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); . > + cl->cl_fsc = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); . > + cl->cl_usc = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); . > + rsc_tmp = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); > + usc_tmp = malloc( sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); . . . -- Jaakko