From owner-freebsd-current@FreeBSD.ORG  Tue Oct  8 08:01:04 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 86FECA21;
 Tue,  8 Oct 2013 08:01:04 +0000 (UTC)
 (envelope-from dumbbell@FreeBSD.org)
Received: from mail.made4.biz (unknown [IPv6:2001:41d0:1:7018::1:3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B5AB2C48;
 Tue,  8 Oct 2013 08:01:04 +0000 (UTC)
Received: from [2001:1b48:10b:cafe:225:64ff:febe:589f] (helo=viking.yzserv.com)
 by mail.made4.biz with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256)
 (Exim 4.80.1 (FreeBSD)) (envelope-from <dumbbell@FreeBSD.org>)
 id 1VTSE1-0001iI-WF; Tue, 08 Oct 2013 10:01:02 +0200
Message-ID: <5253BBB3.3040302@FreeBSD.org>
Date: Tue, 08 Oct 2013 10:00:51 +0200
From: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= <dumbbell@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: sbruno@freebsd.org, 
 "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
Subject: Re: [patch] Re: drm2/radeon dfixed_trunc() warnings
References: <1381095549.1586.7.camel@localhost>
 <1381172676.3091.0.camel@localhost>
In-Reply-To: <1381172676.3091.0.camel@localhost>
X-Enigmail-Version: 1.5.2
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="x1ipNtLQLGRRcmH6wabjkab9ME0JGRmKi"
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Oct 2013 08:01:04 -0000

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--x1ipNtLQLGRRcmH6wabjkab9ME0JGRmKi
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 07.10.2013 21:04, Sean Bruno wrote:
> Proposed patch to eliminate this check.  If I understand the macro
> correctly, there's no way for these checks to ever do anything as bit
> shifting an unsigned will simply clear out the value.  So, the check fo=
r
> <0 is completely bogus?

Hello!

I think you're right. I saw Clang reporting those warnings. Coverity has
many more. I didn't want to fix them for now, to ease future merges from
Linux.

The plan is to submit patches to upstream at some point.

Thanks for the patch! I should prepare a branch to store that kind of fix=
es.

--=20
Jean-S=E9bastien P=E9dron


--x1ipNtLQLGRRcmH6wabjkab9ME0JGRmKi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlJTu70ACgkQa+xGJsFYOlNkHACgz4Pjn22okp+9A+Foa9lRonzI
UfAAn1sc/ENt6smUhtzdGhbv5r8wYJIG
=lvmN
-----END PGP SIGNATURE-----

--x1ipNtLQLGRRcmH6wabjkab9ME0JGRmKi--