From owner-freebsd-current@FreeBSD.ORG Thu Sep 8 05:25:45 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18A3916A41F for ; Thu, 8 Sep 2005 05:25:45 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.194]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EDF343D45 for ; Thu, 8 Sep 2005 05:25:44 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by zproxy.gmail.com with SMTP id 8so1020650nzo for ; Wed, 07 Sep 2005 22:25:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:subject:message-id:reply-to:mime-version:content-type:content-disposition:user-agent; b=QrLEdC0EasiEGoBharwKQkv5ItZL9Db5jk0Ms0BubNOKB7p1UxREH6+FQU/U8UaeVJxEiKb7h2QRIe3JRoZHejOkKZ68BCCqhuUGn4SiQ/sgKqv4CgmnDxKtyHE8zv0PqkubThFgP1SafkBcyU5MeAcON+wzm+xrCCt2vkcMByM= Received: by 10.36.220.69 with SMTP id s69mr4497780nzg; Wed, 07 Sep 2005 22:25:44 -0700 (PDT) Received: from michelle.rndsoft.co.kr ( [211.32.202.211]) by mx.gmail.com with ESMTP id 34sm8028121nza.2005.09.07.22.25.43; Wed, 07 Sep 2005 22:25:44 -0700 (PDT) Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.1/8.13.1) with ESMTP id j885MF6q012779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Sep 2005 14:22:15 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j885MFI6012778 for freebsd-current@freebsd.org; Thu, 8 Sep 2005 14:22:15 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Thu, 8 Sep 2005 14:22:15 +0900 From: Pyun YongHyeon To: freebsd-current@freebsd.org Message-ID: <20050908052215.GB11743@rndsoft.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Subject: Call for testers : bge(4) patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2005 05:25:45 -0000 Hi! Patch fixes several bugs in bge(4) and makes it work on any platforms. Patch changes . Give up endianness access and switch to native endian format while accessing hardware. Since I don't have data sheet of Tigon3 I can't sure it's possible to use endianness access but NetBSD/OpenBSD also uses native endian format and data sheet for Tigon1/Tigon2 explicitly says that it requires native endian access. [1] . Remove rman_get_virtual(9) and use bus_space_write_4(9). [1] . Change return code of bge_eeprom_getbyte() when timeout error occurrs. [2] . Add a mutex to protect jumbo frame list handling such that jumbo frame now works on SMP. . ifdef out "no free jumbo buffers" printf calls as numerous printf messages make system unusable under jumbo buffer shortage. It's well demonstrated with netperf UDP tests. . Don't invoke bus_dmamap_destroy(9) for DMA maps which were created with bus_dmamem_alloc(9). . Add missing bus_dmamap_sync(9) in bge_txeof(). . Add missing bus_dmamap_sync(9) in bge_encap(). . Use #ifndef __NO_STRICT_ALIGNMENT instead of #ifndef __i386__ to check whether target system is strict alignment architecture. . Use callout_init_mtx(9) and add callout_drain(9) to bge_detach(). . Reorder detach path so have detach work. . Reject driver detach when there are any references to jumbo buffers. Previously it was lead to reference to freed memory. [1] : Obtained from OpenBSD via NetBSD. [2] : Submitted by jkim. The patch can be obtained from: http://people.freebsd.org/~yongari/bge.patch.0908 The patch was reviewed by marius and jkim and tested on i386(SMP), sparc64(SMP), amd64. Thanks. -- Regards, Pyun YongHyeon