From owner-cvs-all@FreeBSD.ORG Mon Sep 18 22:33:36 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65BA016A47B for ; Mon, 18 Sep 2006 22:33:36 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35]) by mx1.FreeBSD.org (Postfix) with SMTP id 4176543D55 for ; Mon, 18 Sep 2006 22:33:35 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: (qmail 74184 invoked by uid 86); 18 Sep 2006 23:10:49 -0000 Received: from unknown (HELO ?127.0.0.1?) (204.112.0.40) by ems01.seccuris.com with SMTP; 18 Sep 2006 23:10:49 -0000 Message-ID: <450F1EC1.4060106@FreeBSD.org> Date: Mon, 18 Sep 2006 17:33:37 -0500 From: "Christian S.J. Peron" User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) MIME-Version: 1.0 To: Jung-uk Kim References: <200609182218.k8IMIMUT059300@repoman.freebsd.org> In-Reply-To: <200609182218.k8IMIMUT059300@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2006 22:33:36 -0000 Jung-uk Kim wrote: > jkim 2006-09-18 22:18:22 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Do not strip VLAN tag in promiscuous mode. > > Revision Changes Path > 1.148 +28 -15 src/sys/dev/bge/if_bge.c > > > I don't think this is right. An interface does not have to be in promiscuous mode in order to have BPF peers attached to it. If this is being done to ensure that vlan info is preserved for things like tcpdump, the correct fix is to use bpf_peers_present() instead. This issue has been discussed between myself, jhb, and andre for a couple of days now. The correct fix is to teach bpf to look at the mbuf and re-construct and insert the vlan tags before passing it through bpf_filter (and on to any peers), assuming the hardware is handling stripping and inserting vlan tags. I have agreed to work on this, time permitting. -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team