From owner-freebsd-ruby@freebsd.org  Mon Aug  3 08:29:25 2015
Return-Path: <owner-freebsd-ruby@freebsd.org>
Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D79D9AF57D
 for <freebsd-ruby@mailman.ysv.freebsd.org>;
 Mon,  3 Aug 2015 08:29:25 +0000 (UTC)
 (envelope-from info@toco-domains.de)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 66D8E1398
 for <freebsd-ruby@freebsd.org>; Mon,  3 Aug 2015 08:29:25 +0000 (UTC)
 (envelope-from info@toco-domains.de)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 639939AF57C; Mon,  3 Aug 2015 08:29:25 +0000 (UTC)
Delivered-To: ruby@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 633639AF57B
 for <ruby@mailman.ysv.freebsd.org>; Mon,  3 Aug 2015 08:29:25 +0000 (UTC)
 (envelope-from info@toco-domains.de)
Received: from toco-domains.de (mail.toco-domains.de [176.9.39.170])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 298941397;
 Mon,  3 Aug 2015 08:29:24 +0000 (UTC)
 (envelope-from info@toco-domains.de)
Received: from [0.0.0.0] (mail.toco-domains.de [176.9.39.170])
 by toco-domains.de (Postfix) with ESMTPA id B27FB1B22847;
 Mon,  3 Aug 2015 10:29:15 +0200 (CEST)
Subject: Re: [Gitlab] Current Status of the port
To: Steve Wills <swills@FreeBSD.org>
References: <55BA3B55.5010000@toco-domains.de>
 <20150730152241.GC82229@mouf.net> <55BA4532.40107@toco-domains.de>
 <20150731135045.GA49801@mouf.net> <55BB8272.3060900@toco-domains.de>
 <20150731143935.GC49801@mouf.net> <55BB8B17.7050509@toco-domains.de>
 <20150731174219.GD49801@mouf.net>
Cc: ruby@freebsd.org
From: Torsten Zuehlsdorff <info@toco-domains.de>
Message-ID: <55BF265B.9090401@toco-domains.de>
Date: Mon, 3 Aug 2015 10:29:15 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150731174219.GD49801@mouf.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-ruby@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: FreeBSD-specific Ruby discussions <freebsd-ruby.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ruby>,
 <mailto:freebsd-ruby-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ruby/>
List-Post: <mailto:freebsd-ruby@freebsd.org>
List-Help: <mailto:freebsd-ruby-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ruby>,
 <mailto:freebsd-ruby-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2015 08:29:25 -0000

Hello,

>> # cd /usr/ports/devel/rubygem-gitlab_git-rails41
>> # portlint -AC
>> FATAL: Makefile: the last line of a slave port's Makefile has to be
>> .include "${MASTERDIR}/Makefile"
>> FATAL: Makefile: extra item "MASTERDIR" placed in the PORTNAME section.
>> FATAL: Makefile: extra item "PKGNAMESUFFIX" placed in the LICENSE section.
>> WARN: Consider to set DEVELOPER=yes in /etc/make.conf
>> 3 fatal errors and 1 warning found.
>
> portlint doesn't really fully grok slave ports, unless I'm mistaken, so use
> your judgement here, but the include does need to be last.

Okay, will fix.

>> When including the Master-Makefile in the last line, the PKGNAMESUFFIX
>> for example is not used.
>
> Change the master port to use ?= instead of = for the things you want to override.

This works, but increases the number of changed ports ;)

Also it just remove one FATAL error. This other 2 persists. Is this 
enough or should i do further research?

Greetings,
Torsten