From nobody Mon Jan 20 21:52:58 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcPGM4zGGz5l1L8 for ; Mon, 20 Jan 2025 21:52:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcPGM4Vn4z4JBX for ; Mon, 20 Jan 2025 21:52:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737409979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LC2DUH1zouUMOnfQjIHUSh8zOh5Y4ubhtFjVWREVDnQ=; b=BraczktX2rmnVDx85WTUAFbM5x/whnW+z6c7jJ4jI+/QAmlY4u4kVWmNVW2ytjs0H8AiBA 58RZ3r5FZa4LaqUdFBXht1+m8XurWPvLhs+6cNgCvmaCI8QkmFnMS8o7iLKRAMrUFWRtTq qUdCw7/wHUnnODsuzvbUt9eyijMumiHop23Y6EFL/vbBWesMWywdBwlsyjQCyQRP4+JPiD ObOgv4izEL5slJzBxuou+/n9QAgXo9uR1bZpllFiysDNws+xFhthlKgFPgJOkbDVQQU90X TXTi9PmGTI61FwBmylBp+XNVM1QG3OL+F6swLOLng63k8j4ul1kXinkv5nTcfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737409979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LC2DUH1zouUMOnfQjIHUSh8zOh5Y4ubhtFjVWREVDnQ=; b=M3QLdnCYq6Brb+3WjEk/9ifIvRYpEK1NUMm+dl8pcBtfDYSrs2Y2aKifvBvDph1Ep4HkvV Ij6e5/+0wMlRB2J6u2yuuuKhtbV2kpWKhaAdlv3NvaOy9b6hTSPgQVR9qnwEp9m9p3oJDM OcOMhux+fFBXUzkrhrUizNUQYrRKynuFpLQxLB3GXA5+PT7H3c4ic2An7f03T5TlCRF60v N2crw80jYvascXYZZwBLcB0AKnn/8cop6gEd7Gil7LaN2uscE6oDopYGndF9XHe43bOckE QH8ua+UwbsZNxSSKnjhLEjmLIgpMgvMCqip2x2dRc+afVGWFubHlnkxXSDgJug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737409979; a=rsa-sha256; cv=none; b=ma/fQ5RBr1B81Gx40JB8vqaAXifklRykY9pbXNbUiRPPdmqToJy2VOhsltXKuuEOdZ0/ch Ggo+ygi8Idnl49PmrJ4fiRKHM+jscR50F/qfA1uQQThalPQ8sWr50iE736TQyTQsVx03Hf XAWAeROfJVra2Kh5CwqziikDEO3zZ9Qo9mRUgzSPFiqXhLNKDGAM87piDcPodSOFHPLXhr ui/jnJpv0NleqokU78vaS/OLDc/h4ksJzoLrGMfxJt5g7Yn95G6Qs3Oapm3RhvFn+uJZYE 7IISm17aLXUwkUqkFM2xQ3RJjOXeGvpLMvpArteXfVEJQWjNyPt9MFmjguRrlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YcPGM3jR4zfC2 for ; Mon, 20 Jan 2025 21:52:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50KLqxaT039313 for ; Mon, 20 Jan 2025 21:52:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50KLqxEt039311 for net@FreeBSD.org; Mon, 20 Jan 2025 21:52:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 284186] NFS v4.2: improve change_attr_type Date: Mon, 20 Jan 2025 21:52:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284186 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D709c18911ad70978d47198556c0fb1c0e= 703fb68 commit 709c18911ad70978d47198556c0fb1c0e703fb68 Author: Rick Macklem AuthorDate: 2025-01-20 21:51:33 +0000 Commit: Rick Macklem CommitDate: 2025-01-20 21:51:33 +0000 nfsd: Add support for the NFSv4.2 change_attr_type attribute Richard Kojedzinszky reported an intermittent problem where the Linux NFSv4.2 client would sometimes not see changes done to a directory by another client, although the change attribute for the directory had changed. A test patch that added the change_attr_type attribute to the server and always returned NFS4_CHANGE_TYPE_VERSION_COUNTER_NOPNFS seems to have resolved the issue. Somewhat oddly, the Linux knfsd server does not support this attribute but does not seem to exhibit the stale caching problem. This patch uses the VFCF_FILEREVINC flag on a file system (UFS, ZFS) to return NFS4_CHANGE_TYPE_VERSION_COUNTER_NOPNFS. It also returns NFS4_CHANGE_TYPE_TIME_METADATA if VFCF_FILEREVCT is set, which may be useful for exported fuse file systems. PR: 284186 Reported by: Richard Kojedzinszky Tested by: Richard Kojedzinszky MFC after: 2 weeks sys/fs/nfs/nfs_commonsubs.c | 32 ++++++++++++++++++++++++++++++++ sys/fs/nfs/nfsproto.h | 11 ++++++++++- 2 files changed, 42 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=