From owner-freebsd-current@FreeBSD.ORG Fri Apr 20 00:44:49 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1365106566B for ; Fri, 20 Apr 2012 00:44:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id AACF28FC0A for ; Fri, 20 Apr 2012 00:44:49 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEADyxkE+DaFvO/2dsb2JhbABDFoVRrHCCCQEBAQMBAQEBICsgCwUWDgoCAg0ZAikBCSYGCAcEARwEh2kFC6dtkwGBL4lChF6BGASTRYIsgRGPK4MDgUA X-IronPort-AV: E=Sophos;i="4.75,450,1330923600"; d="scan'208";a="165826297" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 19 Apr 2012 20:44:37 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id EE9C6B4022; Thu, 19 Apr 2012 20:44:37 -0400 (EDT) Date: Thu, 19 Apr 2012 20:44:37 -0400 (EDT) From: Rick Macklem To: Andrey Simonenko Message-ID: <120749772.3115727.1334882677955.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <20120419125436.GA82169@pm513-1.comsys.ntu-kpi.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692) Cc: FreeBSD-Current Subject: Re: mountd, rpc.lockd and rpc.statd patches for testing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2012 00:44:50 -0000 Andrey Simonenko wrote: > On Mon, May 30, 2011 at 04:56:02PM -0400, Rick Macklem wrote: > > Hi, > > > > I have patches for the mountd, rpc.statd and rpc.lockd daemons > > that are meant to keep them from failing when a dynamically > > selected port# is not available for some combination of > > udp,tcp X ipv4,ipv6 > > > > If anyone would like to test these patches, they can be found > > at: > > http://people.freebsd.org/~rmacklem/mountd.patch > > statd.patch > > lockd.patch > > > > Although I think I got them correct, they are rather big and ugly. > > > > I have checked this update for mountd in 10-CURRENT and has two > questions: > > 1. What is the sense to try to use the same port number for all > supported netconfigs if specific port number is not given in > a command line option? > Well, there was a discussion of this on one of the mailing lists at the time. I started with a much simpler patch that didn't try and make all 4 combinations use the same port#, but others felt that was important. (Something about tracking what port# were in use, but I can't quite recall. If you want to know the reasoning, look for the thread that would have been shortly before the commit.) > 2. What is the sense of specifying specific IP addresses for mountd > and > similar RPC programs that do not have predefined port numbers? > I'm not sure what you are asking here? (Are you referring to the "-h" command line option?) > > One comment for netconfig related functions usage. Each setnetconfig() > call allocates memory and depending on implementation can use other > resources, so endnetconfig() should be called before reusing netconfig > handle. > _ Ok, I'll take a look someday. Since it happens a finite number of times, any leak should be bounded and, as such, shouldn't cause serious problems. However, I wasn't aware of the above and it should be fixed. rick > ------------------------------------------- > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org"