From owner-freebsd-alpha@FreeBSD.ORG  Sat May 24 13:30:24 2003
Return-Path: <owner-freebsd-alpha@FreeBSD.ORG>
Delivered-To: freebsd-alpha@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EC82637B401
	for <freebsd-alpha@freebsd.org>; Sat, 24 May 2003 13:30:24 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1317243F85
	for <freebsd-alpha@freebsd.org>; Sat, 24 May 2003 13:30:24 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.8p1/8.12.3) with ESMTP id h4OKUNQg099468;
	Sat, 24 May 2003 13:30:23 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.8p1/8.12.3/Submit) id h4OKUNdi099467;
	Sat, 24 May 2003 13:30:23 -0700 (PDT)
	(envelope-from rizzo)
Date: Sat, 24 May 2003 13:30:23 -0700
From: Luigi Rizzo <luigi@freebsd.org>
To: Peter Wemm <peter@wemm.org>
Message-ID: <20030524133023.A99306@xorpc.icir.org>
References: <20030519004914.B46011@xorpc.icir.org>
	<20030524202652.68A9F2A7EA@canning.wemm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030524202652.68A9F2A7EA@canning.wemm.org>;
	from peter@wemm.org on Sat, May 24, 2003 at 01:26:52PM -0700
cc: freebsd-alpha@freebsd.org
Subject: Re: [FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64
X-BeenThere: freebsd-alpha@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the Alpha <freebsd-alpha.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-alpha>
List-Post: <mailto:freebsd-alpha@freebsd.org>
List-Help: <mailto:freebsd-alpha-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 May 2003 20:30:25 -0000

On Sat, May 24, 2003 at 01:26:52PM -0700, Peter Wemm wrote:
> Luigi Rizzo wrote:
> 
> >      if (cmd->opcode == O_LOG)
> >  	cmd += F_LEN(cmd);
> > +#ifdef I386
> >      fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr;
> > +#else
> > +    bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs));
> > +#endif
> >  
> 
> This is not a 'reviewed-by:', but these should be #ifdef __i386__
> rather than #ifdef I386.

yes, i posted the wrong one... thanks

	luigi
>