From owner-freebsd-ports@FreeBSD.ORG Fri Jan 21 15:27:33 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FD6316A4CE; Fri, 21 Jan 2005 15:27:33 +0000 (GMT) Received: from ritamari.vonostingroup.com (ip193-230.digitalrealm.net [216.144.193.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98F1E43D2F; Fri, 21 Jan 2005 15:27:32 +0000 (GMT) (envelope-from laszlof@tvog.net) Received: from adsl-68-72-248-38.dsl.sfldmi.ameritech.net ([68.72.248.38] helo=tvog.net) by ritamari.vonostingroup.com with esmtpa (Exim 4.43 (FreeBSD)) id 1Cs0hZ-0003ol-TA; Fri, 21 Jan 2005 10:27:58 -0500 Message-ID: <41F11F5B.9020507@tvog.net> Date: Fri, 21 Jan 2005 10:27:23 -0500 From: Frank Laszlo User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Conrad J. Sabatier" References: <20050117131440.2486ac2a@dolphin.local.net> <41EC175F.8060805@tvog.net> <20050117225702.GA31708@xor.obsecurity.org> <20050119005427.70f7b3ac@dolphin.local.net> <20050119072607.GJ1033@k7.mavetju> <20050121065110.100b445f@dolphin.local.net> In-Reply-To: <20050121065110.100b445f@dolphin.local.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ritamari.vonostingroup.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [26 6] X-AntiAbuse: Sender Address Domain - tvog.net X-Source: X-Source-Args: X-Source-Dir: cc: freebsd-ports-bugs@freebsd.org cc: Edwin Groothuis cc: freebsd-ports@freebsd.org cc: Kris Kennaway Subject: Re: Bug in ports system's DISTFILES handling? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2005 15:27:33 -0000 Conrad J. Sabatier wrote: >On Wed, 19 Jan 2005 18:26:07 +1100, Edwin Groothuis >wrote: > > > >>On Wed, Jan 19, 2005 at 12:54:27AM -0600, Conrad J. Sabatier wrote: >> >> >>>This just seems less than intuitive, if you ask me, especially given >>>that the += operator does work with other variables without >>>requiring the explicit definition of an initial value first. >>> >>> >>Euhm... you need to keep a couple of things seperated: >> >>- The ports framework (bsd.port.mk) consists of two parts: >> >> - One to set the basic variables which are not directly port >> related, for example OSVERSION, WANT_GNOME and LOCALBASE. >> This is called "bsd.port.pre.mk". >> >> - One to set the basic variables which are directly port >> related, for example LIB_DEPENDS and the pre/do/post targets. >> This is called "bsd.port.post.mk". >> >>The definition of DISTFILES itself is defined in the second part. >>Why? I don't know. It shouldn't have, because all the necessary >>information to build DISTFILES (DISTNAME and EXTRACT_SUFX) are >>defined in the "bsd.port.pre.mk" part. >> >> >> >>>I mean, if this were something that was consciously decided on, >>>that's one thing, but the lack of consistency would seem to indicate >>>that it's just not as well implemented as it could/should be. >>> >>> >>I wouldn't go that far. I don't think you're the first who steps >>into this problem and goes "euhm... this doesn't make sense", but >>I think you're the first who goes "euhm... guys! this doesn't make >>sense!" >> >>For example see biology/garlic: >> DISTFILES= ${DISTNAME}${EXTRACT_SUFX} >> .if !defined(NOPORTDOCS) >> DISTFILES+= ${DISTNAME}-doc${EXTRACT_SUFX} >> .endif >> >>I won't say that >> -DISTFILES= ${DISTNAME}${EXTRACT_SUFX} >> .if !defined(NOPORTDOCS) >> DISTFILES+= ${DISTNAME}-doc${EXTRACT_SUFX} >> .endif >>should work, but I would say that: >> -DISTFILES= ${DISTNAME}${EXTRACT_SUFX} >> +.include >> .if !defined(NOPORTDOCS) >> DISTFILES+= ${DISTNAME}-doc${EXTRACT_SUFX} >> .endif >>should work. >> >>Or even: >> DISTFILES= ${DISTNAME}${EXTRACT_SUFX} >> .if !defined(NOPORTDOCS) >> +EXTRA_DISTFILES+=${DISTNAME}-doc${EXTRACT_SUFX} >> .endif >>which would work as EXTRA_PATCHES. >> >>Or to make it easiest of all: >> -DISTFILES= ${DISTNAME}${EXTRACT_SUFX} >> +DISTFILES= ${DEFAULTDISTFILE} >> .if !defined(NOPORTDOCS) >> DISTFILES+= ${DISTNAME}-doc${EXTRACT_SUFX} >> .endif >>and then DEFAULTDISTFILE is in the "bsd.port.pre.mk" defined. This >>way it's easy to for the Makefile of chinese/xcin25: >> DISTFILES= ${DEFAULTDISTFILE} >> chewing-2002Jan07-snapshot.tar.gz >>No confusion about things here. >> >>I would go for the last one, and volunteer to send patches when >>there is some consensus. >> >> > >Yes, I like that last version, too. I say go for it. :-) > > *nod* __________________________________________________ Frank Laszlo System Administrator The VonOstin Group Email: laszlof@tvog.net WWW: http://www.vonostingroup.com Mobile: 248-863-7584