From owner-cvs-all Wed Jun 5 7:48:59 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 6FE1B37B404; Wed, 5 Jun 2002 07:48:55 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g55EldCd051034; Wed, 5 Jun 2002 16:47:39 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Jake Burkholder Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/common ufsread.c src/sys/boot/sparc64/boot1 Makefile boot1.c In-Reply-To: Your message of "Wed, 05 Jun 2002 11:03:03 EDT." <20020605110302.D54588@locore.ca> Date: Wed, 05 Jun 2002 16:47:39 +0200 Message-ID: <51033.1023288459@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020605110302.D54588@locore.ca>, Jake Burkholder writes: >Apparently, On Wed, Jun 05, 2002 at 05:00:53AM -0700, > Poul-Henning Kamp said words to the effect of; > >> phk 2002/06/05 05:00:53 PDT >> >> Modified files: >> sys/boot/common ufsread.c >> sys/boot/sparc64/boot1 Makefile boot1.c >> Log: >> Make sparc64 share ufsread.c with i386. > >Wouldn't it be better to link with this file rather than #including it? In theory yes, but in practice I think not. The various platforms have made different choices for how to deal with stuff like memcpy, strcmp and so on, so I think trying to keep under the size-limits while putting this in a separate object file will be non-trivial. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message