From owner-cvs-all@FreeBSD.ORG Sun Jul 31 08:23:53 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4906616A41F; Sun, 31 Jul 2005 08:23:53 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from mailout07.sul.t-online.com (mailout07.sul.t-online.com [194.25.134.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 931BF43D49; Sun, 31 Jul 2005 08:23:52 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from fwd32.aul.t-online.de by mailout07.sul.t-online.com with smtp id 1Dz96s-0006oM-02; Sun, 31 Jul 2005 10:23:50 +0200 Received: from Andro-Beta.Leidinger.net (Ze5vpYZbYe0Wugb8v++WsgAKC9-kXrnWPOt8p8BUIbe6ADLaaYu0cK@[84.165.251.203]) by fwd32.sul.t-online.de with esmtp id 1Dz96n-1xnq8u0; Sun, 31 Jul 2005 10:23:45 +0200 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id j6V8NhQT027793; Sun, 31 Jul 2005 10:23:44 +0200 (CEST) (envelope-from netchild@FreeBSD.org) Date: Sun, 31 Jul 2005 10:23:43 +0200 From: Alexander Leidinger To: des@des.no (Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?=) Message-ID: <20050731102343.35bc4aa9@Magellan.Leidinger.net> In-Reply-To: <863bpvmnww.fsf@xps.des.no> References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no> Organization: FreeBSD X-Mailer: Sylpheed-Claws 1.9.13 (GTK+ 2.6.8; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-ID: Ze5vpYZbYe0Wugb8v++WsgAKC9-kXrnWPOt8p8BUIbe6ADLaaYu0cK@t-dialin.net X-TOI-MSGID: f6d788a6-97e1-4807-8b0e-4d03ef3338e6 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Peter Grehan , cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2005 08:23:53 -0000 On Sun, 31 Jul 2005 09:31:59 +0200 des@des.no (Dag-Erling Sm=F8rgrav) wrote: > Alexander Leidinger writes: > > What's more preferred, the use of ".error", or the way you solved it? >=20 > depends on what you think should happen if a user tries >=20 > # make installworld delete-old Ok, point taken. > BTW, I don't really see why {check,delete}-old-* should be restricted > to native environments. DESTDIR might point to e.g. an NFS-exported > filesystem from which thin clients of a different architecture boot. Because of ObsoleteFiles.inc: ---snip--- .if ${MACHINE_ARCH} !=3D "alpha" && ${MACHINE_ARCH} !=3D "sparc64" # 20040130: libkse renamed to libpthread OLD_FILES+=3Dusr/lib/libkse.a OLD_FILES+=3Dusr/lib/libkse.so .endif ---snip--- We could change this to TARGET_ARCH instead, but then the user has to set it, else he removes non-obsolete files. Even when we make it a documented requirement, I don't have a good feeling regarding this. There's too much foot-shooting potential if someone forgets to set it. I think it's more user friendly / ergonomic to keep the current restriction. With the restriction in place you need to have 2 files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src directory on one client to remove the old files. This is a little bit more work, but forces the administrator to think a little bit about what he does. It's part of my "as failsafe as possible" design of this feature. I don't object when someone wants to remove the restriction based upon a decission of a majority (committers, user complains, whatever). Bye, Alexander. --=20 Where do you think you're going today? http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint =3D C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7