Date: Tue, 21 Jun 2011 01:31:28 -0700 From: Xin LI <delphij@delphij.net> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r223356 - head/sbin/geom/class/part Message-ID: <4E0056E0.2030104@delphij.net> In-Reply-To: <4E0038F1.3050906@yandex.ru> References: <201106210446.p5L4k0IZ080002@svn.freebsd.org> <4E00263C.4040802@yandex.ru> <4E00347A.80407@delphij.net> <4E0038F1.3050906@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 23:23, Andrey V. Elsukov wrote: > On 21.06.2011 10:04, Xin LI wrote: >>>> Mod the offset padding by alignment. Without this change we may >>>> pad too much when underlying GEOM object have a zero stripesize. >> >>> No. In any way offset value could not be greater than mediasize. >> I don't think this changeset do anything with mediasize? > > I did mean that it could not pad too much. When stripesize is zero the > stripeoffset points to real offset from the beginning of device. > In case when we have nested partitioning schemes like MBR + BSD, > stripeoffset of BSD slice could help align partition to the device. Yes agreed. >>> And it do nothing when alignment value is 1. >> >> No, an alignment value of 1 makes offset = 0, which is the intended >> behavior. >> >> Or did I misunderstood the code? > > The problem that Kris reported was not here. > I think this change is just for the reassurance. Well, I think semantically the offset variable expects a value that represents in-stripe offset rather than the real (against the media) offset that GEOM returns. I'll defer the merge until your change have been merged. Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJOAFbgAAoJEATO+BI/yjfBNPkH/1HEUxWDuUFoO+4r8FGuTyek 8oFYip67HztN5l8CWiOP61utGPyMLcyk5hS6CwkvAiHaChQeGp75Sp/16D0xkyiT qcJOZIUjtTRvkABrLD/M5vLM5nU3cg80quhPmAjXuPytJFBsy7QdP1cjXK7ql0sB bCXMhqWR8oAbQ5rch8BkFlmRQmHEWFVlR2puxUoBi+YrUEKAiv83ghC9UE4H6NT8 trA+UYr+px2AC+opU0yijdscevdVPdJi6mo08EFqbC6ABzIwTR2Ky2LLhdGrmuk+ impuJz4r44LsKvAxOqFn9bZoBLRTxHMkSju4R8kaAfxT3dehTOK2RViI3FaH7Ko= =jRrp -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E0056E0.2030104>