From owner-svn-ports-all@FreeBSD.ORG Mon Oct 28 08:39:39 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 69BF426E; Mon, 28 Oct 2013 08:39:39 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-gg0-f174.google.com (mail-gg0-f174.google.com [209.85.161.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EC25D2B5D; Mon, 28 Oct 2013 08:39:38 +0000 (UTC) Received: by mail-gg0-f174.google.com with SMTP id q3so1174957gge.19 for ; Mon, 28 Oct 2013 01:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=qkkiKax0wOVDS6p0pddmjsaFBTQOpKN+MhDvuPA3O1o=; b=aRdx/LuCYiDAcFJrQf8GSDmz85QDSWV7tc7KiFWN+400WxJFxOY391L4fO66S8+WDD gW9VGG4Dmjk3D+geunNHP7r7AOAyalg9sg3jJ1Wl/kgWOL2aski5Z1cE5o7A0ZmqMRwv iA8TgPL6FQP7Bgsr7rbIzAJ+Fkfm4Lh3w29CjJN3nTs6Azq6+sCmoSYgF+RR381tsjZU ZLzhHU1GDsTmqXXeN+2ziM1LJ1YR6gonuXjVD8bf7kDac+mGKgvQB6ebMwCPzIZlGO4X kWzoSPpRdrVedkGzlMl86RNY5LjgEtbxZqL1mAhiLtMBDSMk0/6dAEx7wPJez3qNzLd2 Y77Q== X-Received: by 10.236.102.46 with SMTP id c34mr94462yhg.101.1382949230657; Mon, 28 Oct 2013 01:33:50 -0700 (PDT) Received: from [192.168.11.100] (201-95-158-158.dsl.telesp.net.br. [201.95.158.158]) by mx.google.com with ESMTPSA id u52sm31240064yhg.5.2013.10.28.01.33.47 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 28 Oct 2013 01:33:49 -0700 (PDT) Sender: Renato Botelho Message-ID: <526E2167.4030309@FreeBSD.org> Date: Mon, 28 Oct 2013 06:33:43 -0200 From: Renato Botelho Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r331439 - head/security/checkpassword References: <201310232232.r9NMWeoP077908@svn.freebsd.org> <20131028045406.GA30390@FreeBSD.org> In-Reply-To: <20131028045406.GA30390@FreeBSD.org> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2013 08:39:39 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 28-10-2013 02:54, Alexey Dokuchaev wrote: > On Wed, Oct 23, 2013 at 10:32:40PM +0000, Renato Botelho wrote: >> New Revision: 331439 >> URL: http://svnweb.freebsd.org/changeset/ports/331439 >> >> [...]=20 >> -NO_STAGE=3D yes >> .include >> [...]=20 >> .if ${PORT_OPTIONS:MDOCS} >> - ${MKDIR} ${DOCSDIR} >> + ${MKDIR} ${STAGEDIR}${DOCSDIR} >> .for f in ${PORTDOCS} >> - ${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR} >> + ${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR} >=20 > Since this port is not actually doing something nasty to build those do= cs, > you could have simply remove .if ${PORT_OPTIONS:MDOCS} check. This wou= ld > make the Makefile cleaner, and you and even drop .include > (but don't forget to adjust -> ). What you are proposing is to always intall docs? Even if user has DOCS option unset? --=20 Renato Botelho GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJSbiFoAAoJEPHw56GfYleQnKgP/24sy0zI2Bea5xtzh1atWWgg hkQoqLH19WVmuf4O8fDyaoT3NvhFVqJ9Df1P4mu88YVX0YWnPno98Gg3H4Ks+tGg as5W1kFKoIMxNVjtXTXrDkQl871BzGc1Tvz8sFomC8ky3iWHuiEGNQpNonOhsdWb R7KY0a8+dHzqAdvHH4vBUpi4Mz8xJXdlg32+yJuG4xgcbVnDFDc2tG4djPp2APEB OIkGUJAr874LM6Vfa/sXAYzh2LuRBkHGoRlUuKEbFXN+u6Qp5qAm1qcbmn8cPnkw UTFcRndDrX3lsHREIoTYjYmLPXGtlX+wu90kr4iZp7QFcmQ/tti+L/Uy4PI0H5ZX pDz7FGWwd9VTQv4kPsLa7IkcYMC1JqPlDi6zzCQ1nNJd5pXjwxyvF9TKk4u6/7la 22+KUesjxnFX3WuEcgRMWf7fui1HDUY95AVTbESGsopwoiyDAO8wI9gnG/2aYUyk nNYiwicPl+l5+sKFD2ldV3WIJtQhCwQgCcALYi5ZoS1cfu/MHFArqke8Qbg2J99f JZVcVtuja8ke6AJj22kOyQUNEjc4UuyNzCqpopTjewXudQOfm0UTLU+PNpYNAGVh 53nBFKtI1bQNyCLWR0lRmIrs5CTLhB0Lf3RCqneugNke2XKTldIylPxjpXvb8eJk TNC6WjTewdjfCIG1TXRn =Kq7c -----END PGP SIGNATURE----- --QDRRxRcbs02m1rRuq8uDBMhfQAj44lv47--