From owner-svn-src-head@FreeBSD.ORG  Thu Jul 25 16:59:20 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id AEC02F11;
 Thu, 25 Jul 2013 16:59:20 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au
 [211.29.132.53])
 by mx1.freebsd.org (Postfix) with ESMTP id 706D8242B;
 Thu, 25 Jul 2013 16:59:20 +0000 (UTC)
Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au
 (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23])
 by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id ABC33D42AC5;
 Fri, 26 Jul 2013 02:59:15 +1000 (EST)
Date: Fri, 26 Jul 2013 02:59:12 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: John Baldwin <jhb@FreeBSD.org>
Subject: Re: svn commit: r253618 - head/sys/dev/usb/gadget
In-Reply-To: <201307241529.35175.jhb@freebsd.org>
Message-ID: <20130726025137.E2782@besplex.bde.org>
References: <201307241832.r6OIWFGc074918@svn.freebsd.org>
 <201307241529.35175.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=Yos2GeoX c=1 sm=1 tr=0
 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117 a=PO7r1zJSAAAA:8 a=JYkn-E3srG0A:10
 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=4v6nFQ3yUQ4A:10 a=6I5d2MoRAAAA:8
 a=ZHBUoalBIWQ8lvIXvfIA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2013 16:59:20 -0000

On Wed, 24 Jul 2013, John Baldwin wrote:

> On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
>> Author: obrien
>> Date: Wed Jul 24 18:32:15 2013
>> New Revision: 253618
>> URL: http://svnweb.freebsd.org/changeset/base/253618
>>
>> Log:
>>   per style(9):
>>      Kernel include files (i.e. sys/*.h) come first; normally, include
>>      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
>>      <sys/cdefs.h>, and it is okay to depend on that.
>
> This is not fully correct.  The consistent style throughout the tree when
> using _FBSDID() is:
>
> #include <sys/cdefs.h>
> __FBSDID()
>
> #include <sys/param.h>
> ...
>
> Please fix these to match that.  It might not be a bad idea to document the
> __FBSDID() practice in style.9 while you are at it.

This ugliness (sys/cdefs.h before __FBSDID()) is to avoid changing all the
includes of sys/param.h and sys/types.h or even anyother.h that followed
the old style rule.

As is common, style(9) documents the rule for sys/cdefs.h before
__FBSDID() only by example.  Its main text wasn't changed and still
emphasizes depending on getting sys/cdefs.h from sys/param.h or
sys/types.h and not from anywhere else.  But almost everywhere else
now includes it too, and with it included before __FBSDID(), almost
all direct includes of it not before __FBSDID() are style bugs.

Bruce