Date: Fri, 22 Jan 2010 10:29:43 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-stable@freebsd.org Cc: Colin <freebsd@southportcomputers.co.uk>, Jeremy Chadwick <freebsd@jdc.parodius.com> Subject: Re: make buildkernel failing on zfs Message-ID: <201001221029.43926.jhb@freebsd.org> In-Reply-To: <20100122111708.GA67643@icarus.home.lan> References: <4B596838.9020609@southportcomputers.co.uk> <20100122094546.GB6681@titania.njm.me.uk> <20100122111708.GA67643@icarus.home.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 22 January 2010 6:17:08 am Jeremy Chadwick wrote: > On Fri, Jan 22, 2010 at 09:45:46AM +0000, N.J. Mann wrote: > > In message <4B596838.9020609@southportcomputers.co.uk>, > > Colin (freebsd@southportcomputers.co.uk) wrote: > > > > > [snip] > > > It goes for a while and then the buildkernel fails with this: > > > > > > cc -O2 -fno-strict-aliasing -pipe -DFREEBSD_NAMECACHE -DBUILDING_ZFS > > > -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc > > > -I/usr/src/sys/modules/zfs/../../cddl/compat/opensolaris > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/commo > > > n/fs/zfs > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common > > > -I/usr/src/sys/modules/zfs/../.. > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/openso > > > laris/common/zfs > > > -I/usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/common > > > -I/usr/src/sys/modules/zfs/../../../include -DHAVE_KERNEL_OPTION_HEADERS > > > -include /usr/obj/usr/src/sys/TED/opt_global.h -I. -I@ -I@/contrib/altq > > > -finline-l > > > imit=8000 --param inline-unit-growth=100 --param > > > large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/TED > > > -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx > > > -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding - > > > Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > > -Wno-pointer-sign -fformat-extensions -Wno-unknown-pragmas > > > -Wno-missing-prototypes -Wno-undef -Wno-strict-pro > > > totypes -Wno-cast-qual -Wno-parentheses -Wno-redundant-decls > > > -Wno-missing-braces -Wno-uninitialized -Wno-unused -Wno-inline > > > -Wno-switch -Wno-pointer-arith -c > > > /usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_z > > > node.c > > > *** Error code 1 > > > > I think this was a temporary problem that has already been fixed. Try > > updating to the latest version and see if that builds okay. > > The FreeBSD tinderbox build system noticed this problem as well, dying > in the same piece of code. It's not you. > > 738 01/21 17:04 FreeBSD Tinderbox (9.0K) [releng_7 tinderbox] failure on amd64/amd64 > 739 01/21 17:44 FreeBSD Tinderbox (8.7K) [releng_7 tinderbox] failure on i386/i386 > > Normally I'd shake my finger at the committer for committing code to > stable branches without testing, but I hold the committer (jhb) in very > high regards and he has a very established history of not breaking > things + doing excellent work. Mistakes happen, we're all human. :-) Kind words aside, in this case the testing wasn't quite adequate. While I did run-test it under UFS, I only built a GENERIC kernel w/o modules which is how I missed ZFS. Given that the patch touched ZFS I really should have built the module. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001221029.43926.jhb>