From nobody Wed Aug 20 11:55:41 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c6PzZ1DYbz64qd2; Wed, 20 Aug 2025 11:55:54 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c6PzY5L9Lz3GSZ; Wed, 20 Aug 2025 11:55:53 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3e570045e05so54739675ab.2; Wed, 20 Aug 2025 04:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755690953; x=1756295753; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5G5w61Gad1kZGRSI8Vt3GR4R79tRxXWuPsfjrKvZeU=; b=JTEURLW8S2jnS6L9lgufdSFygz1PokXnR/132ESlcpDOjmOV23WC7onOfWcdorJ5pq qSZXAJnKN4dYZb6X+gGWf/snsfFnFSS43VBt07hVLZ5Zzev1FV6MtczpPNGUo6sBFzmk c9iFBh4u7g4+N+wF0TprRiVLl6T/3nwkbxBqLfuF9dUmQlhE7wB7jmn4ThLl4p9CzIbr ia3BlT1vJ3qy9lU9DhlhuHsEAgcn7Vg+Pgp2OOtkH68SjleSM4t6o9or3uecnlF9R/NA BY8i24XoRycevvXGGIQFOS/MxSUHTtbj1EZHojAVH7VuLHMNI/MXlw/B/E36RJSKdv58 La8w== X-Forwarded-Encrypted: i=1; AJvYcCU50bxv1bjCZfI+HfzjrhAWpVE7V+aXCZPqwDaTrSP2fC3776+2r+o9WlpiMTNtFyWMgGE89fU5RIDzhfOLsMQ=@freebsd.org, AJvYcCVMvYY28myLtczuk/PJ8uO7m0kPrMb4ala06SWbtwUX2e2JVUrZTpMxbrDerBr5wAILRM2NmOsXNzhvPybRm6ZyCpTd@freebsd.org, AJvYcCX/e/F0OwNrIiZ6sgyy07dziIUeLLL568YOa33ogDOy7vBDYOX/zwxnPhXvjlLhMICOPNVGG/SnHbdYy3q8QxeZVQytxXE=@freebsd.org X-Gm-Message-State: AOJu0YyjeSeK3Vipcz5jd2m4s1cuRi3WgsECewsehPRmSYM0eRJ0QdAd HRRQ3NSOrnYIy1dfYsGhYDsy/vBwQ/12Bf7VksQfCosbPw5Sl8Dvnodf/1pNNfZLI9MeNX7iUUU ZyW68qQmk0frM/Lc9WvXbO3xBAgnI+engvw== X-Gm-Gg: ASbGncubejQQUVj5u3UGLHDAUKVnC2lM5S0fACyMqbEEmi/ZzcIJ+bw+zHVYArMvLj4 J2wKISiY4855254XvQQN+b+I3sra9Wpie87hQ8QJIHppubGZ+w7q7MaNwA3Tjslx7V6Yxi/YzXS lxrkak+Y1odPJ+H7B7bw3k8alVHqm2uUxZtBC1Q8lRPk7Yo29uQ1Bb7SxoMpBFax6qol9/+bF8I 3Fk2vIZPh6xnoetsycVGfrTtylWFxHhRtx26oGCbrQLEmfPBwiV X-Google-Smtp-Source: AGHT+IFRIja7cyj3ZS4iezwnFqad0W3fQVVXyHKD+RdXL2vudJbFxcraZjd9okNxCGIKAIhVcLnXusOWvSq9ZiMLtKw= X-Received: by 2002:a05:6e02:1521:b0:3e5:6a2e:e3bd with SMTP id e9e14a558f8ab-3e67ca22de7mr44725425ab.15.1755690952732; Wed, 20 Aug 2025 04:55:52 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202508192309.57JN9cNK038457@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Wed, 20 Aug 2025 07:55:41 -0400 X-Gm-Features: Ac12FXwNjlGApc2p3tmWIP-VgPQVcugfzzThVAIHYlpQUvXmGd0BQ7aZD42vmsY Message-ID: Subject: Re: git: 75acf71786f2 - main - libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp To: Konstantin Belousov Cc: Aymeric Wibo , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c6PzY5L9Lz3GSZ On Wed, 20 Aug 2025 at 04:12, Konstantin Belousov wrote: > > On Tue, Aug 19, 2025 at 11:09:38PM +0000, Aymeric Wibo wrote: > > The branch main has been updated by obiwac: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=75acf71786f201093b76f45eff03a8665fb79a72 > > > > commit 75acf71786f201093b76f45eff03a8665fb79a72 > > Author: Muhammad Saheed > > AuthorDate: 2025-08-19 23:06:53 +0000 > > Commit: Aymeric Wibo > > CommitDate: 2025-08-19 23:07:15 +0000 > > > > libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp > > This breaks the ABI, of course. > > Or, it makes no sense to have the overhead of symbol versioning if it is > fine to break the ABI. > > Symbol removal should have resulted in the library version bump. libifconfig is an INTERNALLIB without a shared library so the symbol map is just unused.