From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Sep 4 02:50:07 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B22316A419 for ; Tue, 4 Sep 2007 02:50:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 66A5D13C45B for ; Tue, 4 Sep 2007 02:50:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l842o7OI040129 for ; Tue, 4 Sep 2007 02:50:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l842o74q040128; Tue, 4 Sep 2007 02:50:07 GMT (envelope-from gnats) Date: Tue, 4 Sep 2007 02:50:07 GMT Message-Id: <200709040250.l842o74q040128@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Dave Grochowski Cc: Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dave Grochowski List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2007 02:50:07 -0000 The following reply was made to PR ports/116058; it has been noted by GNATS. From: Dave Grochowski To: Danny Pansters Cc: bug-followup@freebsd.org Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8 Date: Mon, 03 Sep 2007 22:18:22 -0400 Hey, Danny Pansters wrote: > Edwin or other: please use attached diff for commit. It's reasonably well > tested. I'll take any fallout (as usual) > > > Hi Dave, > > Thanks for the PR. I wasn't aware of a gtk-qt-engine update yet. Also quite > new to cmake. Please note that generally for existing ports diffs are used, > and shars for new ports (though if you need to add a dir shar or tar are much > easier to use). > Yeah, the thought crossed my mind, but for some reason I went with a shar anyway. Sorry about that. > I've used your PR but reworked/changed it for a few things: > > - having GTK_LIB_DIR etc also be passed as CMAKE_ARGS (based in LOCALBASE, I > reckon that for this that's better tha PREFIX but this may be debatable), > that way we don't need a patch or a files/ directory at all. Another > possiblity is to use REINPLACE_CMD (sed) for these things, pre-configure. > Ok, that makes more sense. However, there are some issues with that: 1. GTK_LIB_DIR should be set to "${LOCALBASE}/lib". 2. Similarly, KDE3_LIB_DIR should be set to "${LOCALBASE}/lib". 3. You cannot pass in GTK_PREFIX, GTK_LIB_DIR, and KDE3_LIB_DIR like that. The values for those are actually pulled from pkg-config. Any parameters passed in will be overwritten anyway when the calls to pkg-config are made. Does it make more sense to pass in the values for those or just use pkg-config to figure them out? The former will require a little more work to achieve, either with some sed magic or a patch. > - re-add lib dependency on kdecore. The kcm module build really requires > kdecore. And I think also for running. > Whoops, that was an accident. > - I like the CMAKE_ARGS way of passing CXX and friends that you used, kept > that in, also used a CMAKE variable for the cmake path, which I expect a new > bsd.cmake.mk to so in the near future (as well as probably providing a > canned-in way to add common cmake args). > I was going to suggest making it: CMAKE?= ${LOCALBASE}/bin/cmake However, I suppose the Makefile will be edited anyway after the introduction of bsd.cmake.mk, so the point is irrelevant. > - I noticed you using the pre-build target, while you probably wanted to > override the do-configure target. To do that you use do-configure and set > HAS_CONFIGURE=yes. Well, that's what I did at least :) > Ok, makes more sense. > I tested on tinderbuild/STABLE and also tested building with gcc42, and > limited runtime testing (that is: look at abiword's GUI) > > Thanks! > > Dan > Well, your update to the port works fine for me as well. Sincerely, Dave Grochowski