From owner-freebsd-bugs  Mon Feb  4  3:30: 6 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 0F28837B426
	for <freebsd-bugs@hub.freebsd.org>; Mon,  4 Feb 2002 03:30:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g14BU1R63577;
	Mon, 4 Feb 2002 03:30:01 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8527637B41B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  4 Feb 2002 03:23:37 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g14BNbI60065;
	Mon, 4 Feb 2002 03:23:37 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200202041123.g14BNbI60065@freefall.freebsd.org>
Date: Mon, 4 Feb 2002 03:23:37 -0800 (PST)
From: Dmitriy Reka <dima@sinsoft.com.ua>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: i386/34607: incorrect PAP authorization in pppd
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         34607
>Category:       i386
>Synopsis:       incorrect PAP authorization in pppd
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 04 03:30:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Dmitriy Reka
>Release:        4.4-STABLE
>Organization:
>Environment:
FreeBSD gw.sif.sumy.ua 4.4-STABLE FreeBSD 4.4-STABLE #0: Tue Nov  6 18:09:22 EET 2001 dima@gw.sif.sumy.ua:/usr/src/sys/compile/SIF  i386
>Description:
I`m trying to connect using Windows ppp client. I`m entering correct username and password, but receive "Login incorrect".
pppd output contains:
"PAP authentication failure for dima"

>How-To-Repeat:
I`m run pppd with switches:
pppd 57600 ttyd1 10.119.1.1:10.119.1.2 auth login debug kdebug 1 refuse-chap require-pap
/etc/ppp/ppp-secrets contains:
dima * test 10.119.1.2

>Fix:
in the file /usr/src/usr.sbin/pppd/auth.c:
lines 679-682 contains:
if (scan_authfile(f, user, our_name, remote,                      
                  secret, &addrs, filename) < 0
    || (secret[0] != 0 && (cryptpap || strcmp(passwd, secret) != 0)
        && strcmp(crypt(passwd, secret), secret) != 0)) {
it must be changed to:
if ((scan_authfile(f, user, our_name, remote,                      
                  secret, &addrs, filename) < 0)
    || (secret[0] != 0 && (cryptpap || strcmp(passwd, secret) != 0)
        && strcmp(crypt(passwd, secret), secret) != 0)) {

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message